Update cmake build to support NEPTUNE cmake (aka use modern cmake and… #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix OpenMP bugs) (#6) Update CMakeLists.txt to: - Bring in updates from NCAR ccpp-physics main as needed and update CMakeLists.txt to modern cmake version 3 - Support NEPTUNE cmake build while retaining compatibility with UFS/SCM - Fix existing bugs for assigning compilation flags: OpenMP on/off wasn't handled correctly, some schemes had host model flags applied twice. Fixing the OpenMP flags triggered an error in the OpenMP-on build in NEPTUNE that this PR fixes
climbfuji
commented
Mar 18, 2025
|
|
||
| project(ccpp_physics | ||
| VERSION 5.0.0 | ||
| LANGUAGES Fortran) | ||
|
|
||
| #------------------------------------------------------------------------------ | ||
| set(PACKAGE "ccpp-physics") | ||
| set(AUTHORS "Grant Firl" "Dustin Swales" "Man Zhang" "Mike Kavulich" ) | ||
| set(AUTHORS "Grant Firl" "Dustin Swales" "Dom Heinzeller" "Man Zhang" "Mike Kavulich") |
There was a problem hiding this comment.
We should add NCAR-CGD folks once they start making contributions to ccpp-physics, too?
climbfuji
requested review from
grantfirl,
rhaesung,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
|
Closing this in favor of an updated and fixed version for UFS (ufs-community fork): ufs-community#259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cmake build to support NEPTUNE cmake (aka use modern cmake and fix OpenMP bugs)
Update CMakeLists.txt to:
TODO: TEST WITH UFS AND/OR SCM