Ufs dev pr246 #1121
Ufs dev pr246 #1121
Conversation
… into updraft_velocity
…vertical advection of updraft velocity
… into updraft_velocity
fixed restart not producing issue 2588 using MERRA2 climatology
… into updraft_velocity
hertneky
requested review from
grantfirl,
rhaesung,
Qingfu-Liu,
dustinswales,
lisa-bengtsson,
JongilHan66 and
mzhangw
as code owners
| @@ -1838,11 +1865,10 @@ subroutine samfdeepcnv_run (im,km,first_time_step,restart, & | |||
| val = 1.e-4 | |||
| if (wc(i) < val) cnvflg(i)=.false. | |||
| endif | |||
| enddo | |||
| enddo | |||
There was a problem hiding this comment.
| enddo | |
| enddo |
| @@ -2929,10 +2955,9 @@ subroutine samfdeepcnv_run (im,km,first_time_step,restart, & | |||
| advfac(i) = min(advfac(i), 1.) | |||
| endif | |||
| enddo | |||
|
|
|||
| dimensions = (horizontal_loop_extent,vertical_layer_dimension) | ||
| type = real | ||
| kind = kind_phys | ||
| intent = out |
There was a problem hiding this comment.
omegaout is only modified if certain conditions are met:
if(((imfshalcnv == imfshalcnv_samf) .or. (imfdeepcnv == imfdeepcnv_samf) &
.or. (imfshalcnv == imfshalcnv_c3) .or. (imfdeepcnv == imfdeepcnv_c3)) &
.and. progomega)then
Therefore, this variable must be intent(inout)?
There was a problem hiding this comment.
Or is the variable allocated only under these conditions? Then it would make sense to test for the variable being allocated instead of the if test in the code (@dustinswales)?
There was a problem hiding this comment.
@climbfuji Good catch. A similar issue was discussed and addressed in ufs-community@43807e6, but this one was missed. It looks like this is a metadata error only, though.
There was a problem hiding this comment.
@grantfirl it looks like I missed this one in the meta file. I'm ok with changing it to inout.
There was a problem hiding this comment.
OK, done. I'll figure out a way to get the fix back into ufs/dev.
There was a problem hiding this comment.
thank you! I'm happy to try to do so as well. It should not require new baselines as progomega is false. (Although those highly optimized -DFASTER tests might...)
There was a problem hiding this comment.
@lisa-bengtsson I think that it can be added to ufs-community#248 without ill effect. It's quasi-related anyway.
This PR syncs NCAR/main up with changes from the ufs/dev branch
ufs/dev PR#246
fv3atm PR#914
ccpp-scm PR#578