ufs-dev PR260 memcheck fixes #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditional jump or move depends on uninitialised value(s) at 0x3826324: merge_ (sfcsub.F:4938) by 0x3844236: sfccycle_ (sfcsub.F:2142) by 0x381AAEA: __gcycle_mod_MOD_gcycle (gcycle.F90:249) by 0x377A070: __gfs_phys_time_vary_MOD_gfs_phys_time_vary_timestep_init (GFS_phys_time_vary.fv3.F90:929) by 0x36DCB22: __ccpp_fv3_gfs_v17_p8_time_vary_cap_MOD_fv3_gfs_v17_p8_time_vary_tsinit_cap (in /export/emc-lw-djovic/wd20dj/sufs/simple-ufs/src/ufs-weather-model/build/ufs_mo» by 0x3590E55: __ccpp_static_api_MOD_ccpp_physics_timestep_init (ccpp_static_api.F90:151) by 0x358EBFE: __ccpp_driver_MOD_ccpp_step (CCPP_driver.F90:128) by 0x1F59E29: __atmos_model_mod_MOD_update_atmos_radiation_physics (atmos_model.F90:277) by 0x1E9CF1C: __module_fcst_grid_comp_MOD_fcst_run_phase_1 (module_fcst_grid_comp.F90:1337) by 0xD68002: ESMCI::FTable::callVFuncPtr(char const*, ESMCI::VM*, int*) (ESMCI_FTable.C:2167) by 0xD650D5: ESMCI_FTableCallEntryPointVMHop (ESMCI_FTable.C:824) by 0x1531C3D: ESMCI::enter_callback(ESMCI::SpawnArg*, void*) (ESMCI_VMKernel.C:1249)
Conditional jump or move depends on uninitialised value(s) at 0x13EEC9BF: ??? (in /usr/lib64/libgfortran.so.5.0.0) by 0x141011F8: ??? (in /usr/lib64/libgfortran.so.5.0.0) by 0x1410150A: ??? (in /usr/lib64/libgfortran.so.5.0.0) by 0x141024FD: ??? (in /usr/lib64/libgfortran.so.5.0.0) by 0x14103294: ??? (in /usr/lib64/libgfortran.so.5.0.0) by 0x140F5CD2: _gfortran_transfer_array (in /usr/lib64/libgfortran.so.5.0.0) by 0x382A58F: getarea_ (sfcsub.F:2920) by 0x3834272: fixrdc_ (sfcsub.F:8528) by 0x38408C6: sfccycle_ (sfcsub.F:1097) by 0x381AAEA: __gcycle_mod_MOD_gcycle (gcycle.F90:249) by 0x377A070: __gfs_phys_time_vary_MOD_gfs_phys_time_vary_timestep_init (GFS_phys_time_vary.fv3.F90:929)
429 bytes in 429 blocks are definitely lost in loss record 2,034 of 3,460 at 0x12D3678B: malloc (vg_replace_malloc.c:446) by 0x37BD678: __mp_thompson_MOD_mp_thompson_run (mp_thompson.F90:748) by 0x36B3C26: __ccpp_fv3_gfs_v17_p8_physics_cap_MOD_fv3_gfs_v17_p8_physics_run_cap (ccpp_FV3_GFS_v17_p8_physics_cap.F90:5153) by 0x358FF4B: __ccpp_static_api_MOD_ccpp_physics_run (ccpp_static_api.F90:415) by 0x358E5A1: __ccpp_driver_MOD_ccpp_step._omp_fn.0 (CCPP_driver.F90:197) by 0x146E0725: GOMP_parallel (in /usr/lib64/libgomp.so.1.0.0) by 0x358EAB3: __ccpp_driver_MOD_ccpp_step (CCPP_driver.F90:174) by 0x1F5AE91: __atmos_model_mod_MOD_update_atmos_radiation_physics (atmos_model.F90:277) by 0x1E9CF1C: __module_fcst_grid_comp_MOD_fcst_run_phase_1 (module_fcst_grid_comp.F90:1337) by 0xD68002: ESMCI::FTable::callVFuncPtr(char const*, ESMCI::VM*, int*) (ESMCI_FTable.C:2167) by 0xD650D5: ESMCI_FTableCallEntryPointVMHop (ESMCI_FTable.C:824) by 0x1531C3D: ESMCI::enter_callback(ESMCI::SpawnArg*, void*) (ESMCI_VMKernel.C:1249)
…ve deallocation if not needed
…t_diag' is false in mp_thompson_run.
95,175 bytes in 1 blocks are definitely lost in loss record 3,375 of 3,526 at 0x12D3678B: malloc (vg_replace_malloc.c:446) by 0x36E1C96: __land_iau_mod_MOD_land_iau_mod_set_control (lnd_iau_mod.F90:149) by 0x35D2165: __gfs_typedefs_MOD_sfcprop_create (GFS_typedefs.F90:2918) by 0x358E181: __gfs_init_MOD_gfs_initialize (GFS_init.F90:90) by 0x1F57136: __atmos_model_mod_MOD_atmos_model_init (atmos_model.F90:715) by 0x1EA00A4: __module_fcst_grid_comp_MOD_fcst_initialize (module_fcst_grid_comp.F90:816) by 0xD68002: ESMCI::FTable::callVFuncPtr(char const*, ESMCI::VM*, int*) (ESMCI_FTable.C:2167) by 0xD650D5: ESMCI_FTableCallEntryPointVMHop (ESMCI_FTable.C:824) by 0x1531C3D: ESMCI::enter_callback(ESMCI::SpawnArg*, void*) (ESMCI_VMKernel.C:1249) by 0x1535AEA: ESMCI::VMK::enter(ESMCI::VMKPlan*, void*, void*) (ESMCI_VMKernel.C:2618) by 0xAECBB8: ESMCI::VM::enter(ESMCI::VMPlan*, void*, void*) (ESMCI_VM.C:1216) by 0xD6556E: c_esmc_ftablecallentrypointvm_ (ESMCI_FTable.C:981)
Introduce prognostic updraft velocity to saSAS and C3 cumulus convection schemes
…phys_reset
Remove GFS_suite_interstitial_{phys,rad}_reset.* (reset in fv3atm CCPP_driver.F90
scrasmussen
requested review from
grantfirl,
rhaesung,
Qingfu-Liu,
dustinswales,
gthompsnWRF,
RuiyuSun,
AndersJensen-NOAA and
mzhangw
as code owners
This was referenced Apr 18, 2025
climbfuji
approved these changes
Apr 19, 2025
grantfirl
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts the NCAR:main branch one PR behind the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated fv3atm PR:
Associated NCAR PR: