Feature: remove physcons from physics #1146
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
requested review from
grantfirl,
rhaesung,
dustinswales,
tanyasmirnova,
joeolson42,
mjiacono,
andrewgettelman,
mdtoyNOAA,
lisa-bengtsson and
haiqinli
as code owners
scrasmussen
force-pushed
the
feature/move-physcons-to-host
branch
from
ae29052 to
34c03cd
Compare
scrasmussen
force-pushed
the
feature/move-physcons-to-host
branch
from
df23606 to
12b64b8
Compare
scrasmussen
force-pushed
the
feature/move-physcons-to-host
branch
2 times, most recently
from
3b8acaf to
765001c
Compare
…n_cp, con_g, con_rd, con_rv, con_cliq, con_cvap, con_eps, con_epsm1, con_fvirt, con_hvap, con_hfus, con_t0c
…n_hvap, con_pi, con_rv, con_g, con_csol, con_tice variables transfered
…, con_hfus, con_cp variables transfered
…on_rv, con_rocp, con_hvap, con_hfus, con_fvirt, con_eps variables transferred
…n_rv, con_eps, con_tice, con_cp, con_hvap, con_hfus, con_pi variables transferred
…n_cp, con_hvap, con_hfus variables transferred
…fvirt variables transferred
… build from missing arguments
…itialized before being used
scrasmussen
force-pushed
the
feature/move-physcons-to-host
branch
from
765001c to
0b83e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Removing physcons module to be inline with the CCPP way of handling constants and variables.
Tests Conducted:
To be done, PR will be in draft until a comparison of the results of
mainand this PR has been done. Those plots will be added to the PR.Documentation:
No new features.