-
Notifications
You must be signed in to change notification settings - Fork 161
ufs-dev #295 #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ufs-dev #295 #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hu@noaa.gov, and Kwun Y. Fung).
equation of GFS PBL scheme. (from @WeiguoWang-NOAA)
…s.f to run from 1 instead of i1/j1 to fix a restart reproducibility issue with NEPTUNE
gcycle update
… feature/3dtke_gfspbl
Slight modification in orographic gravity wave drag (OGWD) scheme
…ne' into combo_20250625
tlim_fgf is defined above this in get_spectra_tau_nstgw but not in get_spectra_tau_okw
Fix warning of: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value. [ZLWB]
Fix Warning: 'jj' may be used uninitialized [-Wmaybe-uninitialized]
@dustinswales Can you update the PR? |
grantfirl
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Identical changes from ufs/dev branch PR295 ufs-community#295.
^There are fewer changes here in #1149 than in PR295. This is because PR295 had additional changes from NCAR:main into ufs-community:ufs/dev, which are not relevant here.