UFS-dev PR#302 #1156
Merged
UFS-dev PR#302 #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0250128/sorc/ufs_model.fd/FV3/ccpp/physics into HEAD
…ochemistry-diagnostics
In particular, allow the ozone scheme to have two extra sets of parameters during the ozone hole without crashing the model.
With a separate index for each photochemistry scheme, we can move the index-finding calls in the conditional for the photochemistry scheme.
…ochemistry-diagnostics
…ochemistry-diagnostics
Adding Integrated Canopy Effects to CCPP/PBL Scheme
grantfirl
requested review from
rhaesung,
dustinswales,
andrewgettelman and
lisa-bengtsson
as code owners
climbfuji
approved these changes
Aug 28, 2025
hertneky
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Identical to ufs-dev ufs-community#302
This PR combines the following ufs/dev PRs:
#264 from @AnningCheng-NOAA
Add MERRA2 aerosol three hourly forcing to drive UFS. The code can be used for more high frequency data, such as hourly forcing or half hour etc. The regression tests run across two day period.
#265 from @DWesl
Adds variables to accumulate water vapor photochemical tendencies from photochemistry, document them in the metadata files (for code generation?), and add code to the photochemistry module to calculate the tendencies due to each term of the parametrization, based on ufs-community#196.
See original PR for full description
#291 from @lisa-bengtsson
Currently there is a dx threshold to not use the prognostic closure in saSAS convection for resolutions coarser than 30km. After testing and evaluation for the Seasonal Forecast System (SFS) linked here, we would like to activate this closure also for SFSv1. Thus, to be able to use this closure in SFS (~50km target) this threshold need to be made larger.
In this PR I'm also making a small correction (units from frac to Pa/s for the updraft omega).
This pull-request will need new baselines for any coarser RT test than C384 using the saSAS convection scheme. It does not impact GFSv17 or GEFSv13 at C1152 or C384 resolution.
Tests Conducted:
These changes were tested with the UFS RTs already. Several tests changed baselines, especially those that use saSAS.
Dependencies:
None
Documentation:
None
Issue (optional):
None
Contributors (optional):
@AnningCheng-NOAA @DWesl @lisa-bengtsson