Skip to content

Conversation

dustinswales
Copy link
Member

Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place.

See ccpp-framework #653 and ccpp-physics #1119

@climbfuji

@climbfuji
Copy link
Collaborator

@dustinswales Note that I had to add commit d5776deebd884ec2c6e179094dd2b575f628f6e1 to compile with the UFS, no regression testing yet. And I still want to look at the compiler flags, I think there are still duplicate flags being used that we can fix.

@climbfuji
Copy link
Collaborator

@dustinswales I had to make several updates and revert a few for the ccpp-physics CMakeLists.txt update. I also closed the original PR for NCAR main and worked on a PR for the UFS in ufs-community: ufs-community/ccpp-physics#259

Would you mind testing with this branch and the same ccpp-framework branch you have been using so far (NCAR/ccpp-framework#653)?

@dustinswales
Copy link
Member Author

@climbfuji The SCM uses NCAR main and the UWM fork is ahead of the NCAR main by a commit, so we can't switch to the UWM physics fork for testing in the SCM.
If you are going to open these changes into the UWM fork, this SCM PR can be closed.

@climbfuji
Copy link
Collaborator

I did.

@grantfirl
Copy link
Collaborator

@dustinswales @climbfuji This should become the PR for ufs-dev-PR259 once that is merged, so let's keep it for now and change the description when it comes around (ufs-community/ccpp-physics#259).

@grantfirl
Copy link
Collaborator

This work was included in #582

@grantfirl grantfirl closed this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants