Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOURCE: @grantfirl
DESCRIPTION OF CHANGES:
flag_for_fast_microphysics_energy_conservation
variable is stored in the CCPP_typedefs/GFDL_interstitial DDT in FV3; this doesn't exist in SCM, so this variable was moved to GFS_typedefs/GFS_control (this now differs from FV3)ISSUE: N/A
ASSOCIATED PRs:
NCAR/ccpp-physics#1153
TESTS CONDUCTED: UFS RTs were run in ufs-community/ccpp-physics#195; The new SDFs were exercised on my Mac for the arm_sgp_summer_1997_A and TWPICE cases.
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated fv3atm PR:
Associated NCAR PR:
REGRESSION TEST CHANGES: None expected from UFS RTs except new tests added. It does look like all tests using GFDL MP v1 are not bit-for-bit, but functionally equivalent. I'm not sure why SCM RTs show differences with the GFDL MP v1 scheme but UFS RTs do not.