-
Notifications
You must be signed in to change notification settings - Fork 103
Crown fire Scott & Reinhardt 2001 #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XiulinGao
wants to merge
74
commits into
NGEET:main
Choose a base branch
from
XiulinGao:crown_fire
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
@samsrabin Thanks Sam! This is now ready for review. |
Is it okay if I wait on reviewing this until the conflicts are resolved? |
@samsrabin yep, that totally makes sense! probably after the RX fire branch is merged into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
science: fire
status: Not Ready
The author is signaling that this PR is a work in progress and not ready for integration.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off Sam Levis and Jackie Shuman's previous work on implementing crown fire into FATES, and @adrifoster 's effort of refactoring SPITFIRE.
I went through the previous code and all the applied equations in Scott & Reinhardt 2001, corrected few errors in equations coded and fixed some coding and logical bugs to make the code now can compile and run when crown fire is turned on. I also did some refactor there so it's compatible with the current SPITFIRE after Adrianna's refactor work.
What the PR does:
Calculate patch level canopy fuel load [kg biomass in total], canopy fuel bulk density [kg biomass / m3], and finds the canopy base height at which the biomass density is above the critical density for vertical fire spreading through canopy
Calculate the minimum fire intensity for initiating a crown fire using EQ 11 in Scott & Reinhardt 2001. If surface fire FI is above this threhsold, there is a crown fire.
Check whether it's a passive or active crown fire by comparing the theoretical crown fire ROS (ROS_active, EQ. 10 in Scott & Reinhardt 2001) to the critical ROS required for sustaining a fully active crown fire (ROS_active_min, EQ. 14).
Update ROS and fire intensity once there is a crown fire using EQ. 21 & 22 in Scott & Reinhardt 2001.
What I added:
I added a statistical model for predicting live canopy water content based on plant phenology (LAI) and soil water condition (soil matric potential) using a similar model structure as EQ. 4 in McNorton and Giuseppe 2024 'A global fuel characteristic model and dataset for wildfire prediction' but changed the original mass-based soil water content to SMP. Currently the parameters are just for testing, nothing is constrained by data. I haven't included these parameters as PFT-specific parameters (which I think it makes sense to do). Let me know if I should do that (only 4 parameters ).
when calculate crown damage, I separate the calculation of crown fraction burned of crown fire from surface fire. When there is only a surface fire, crown fraction burned at cohort still uses the SPITFIRE equation; but when there is a passive crown fire, cohort crown fraction burned now uses EQ. 28 in Scott & Reinhardt 2001 and set to 1 for an active crown fire.
To-Do in the future:
We need to add another live canopy water content model that is based on FATES-HYDRO.
Calculation of the theoretical crown fire rate of spread (ROS_active) and the Crowning Index open wind speed uses fuel characteristics from the fuel model 10, one of the 13 Anderson's fire behavior fuel models. I think these fuel model constants should be included as parameter instead of being hard-coded, since some users might want to switch to different fuel models for calculating the crown fire ROS when their systems are totally different than a timber forest. But adding 10+ new parameters does not make sense to me. This can be something to discuss in the future.
Collaborators:
@slevis-lmwg @jkshuman @adrifoster @samsrabin @ckoven @mpaiao @lmkueppers
#857
#1108
Expectation of Answer Changes:
Expect answer change when crown fire is turned on.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: