radiation refactors - rad_error and rad profile diagnostics #1397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This set of changes addresses isues brought up by @mvdebolskiy related to coupling radiation with FATES and CAM: #1376 (comment) . This led to a generalized refactor of radiation diagnostics, particularly radiation profiles, and how these things are initialized and written to output given the nature of the normalized radiation calls (ie that the current day's albedo is calculated at the end of the previous timestep).
This PR has a sibling PR in NorESMhub: https://github.com/NorESMhub/fates/pull/17/files
Collaborators:
@mvdebolskiy
Expectation of Answer Changes:
yes, this will change fates radiation history variables (high frequency multi-layer canopy output), but those only. This is because more attention is being paid to when they are zero'd and when they are ignored.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: