Skip to content

radiation refactors - rad_error and rad profile diagnostics #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

radiation refactors - rad_error and rad profile diagnostics #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b73443f
Fixes to rad_error to accomodate zenith and do-albedo consistency
rgknox Apr 24, 2025
32aad89
Merge branch 'main' into trivial-zenith-defaults-raderrorfix
rgknox Apr 24, 2025
4bbe49e
initializing radiation error diagnostics as ignore instead of zero.
rgknox May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions biogeochem/EDPatchDynamicsMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3213,10 +3213,6 @@ subroutine fuse_2_patches(csite, dp, rp)
rp%c_stomata = (dp%c_stomata*dp%area + rp%c_stomata*rp%area) * inv_sum_area
rp%c_lblayer = (dp%c_lblayer*dp%area + rp%c_lblayer*rp%area) * inv_sum_area

! Radiation
rp%rad_error(1) = (dp%rad_error(1)*dp%area + rp%rad_error(1)*rp%area) * inv_sum_area
rp%rad_error(2) = (dp%rad_error(2)*dp%area + rp%rad_error(2)*rp%area) * inv_sum_area

rp%area = rp%area + dp%area !THIS MUST COME AT THE END!

!insert donor cohorts into recipient patch
Expand Down
18 changes: 9 additions & 9 deletions biogeochem/FatesPatchMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ module FatesPatchMod
real(r8) :: c_stomata ! mean stomatal conductance of all leaves in the patch [umol/m2/s]
real(r8) :: c_lblayer ! mean boundary layer conductance of all leaves in the patch [umol/m2/s]

real(r8),allocatable :: nrmlzd_parprof_pft_dir_z(:,:,:,:) !num_rad_stream_types,nclmax,maxpft,nlevleaf)
real(r8),allocatable :: nrmlzd_parprof_pft_dif_z(:,:,:,:) !num_rad_stream_types,nclmax,maxpft,nlevleaf)
real(r8),allocatable :: nrmlzd_parprof_pft_dir_z(:,:,:) ! nclmax,maxpft,nlevleaf)
real(r8),allocatable :: nrmlzd_parprof_pft_dif_z(:,:,:) ! nclmax,maxpft,nlevleaf)

!---------------------------------------------------------------------------

Expand Down Expand Up @@ -369,8 +369,8 @@ subroutine ReAllocateDynamics(this)
allocate(this%fabd_sha_z(ncan,numpft,nveg))
allocate(this%fabi_sun_z(ncan,numpft,nveg))
allocate(this%fabi_sha_z(ncan,numpft,nveg))
allocate(this%nrmlzd_parprof_pft_dir_z(num_rad_stream_types,ncan,numpft,nveg))
allocate(this%nrmlzd_parprof_pft_dif_z(num_rad_stream_types,ncan,numpft,nveg))
allocate(this%nrmlzd_parprof_pft_dir_z(ncan,numpft,nveg))
allocate(this%nrmlzd_parprof_pft_dif_z(ncan,numpft,nveg))
allocate(this%ed_parsun_z(ncan,numpft,nveg))
allocate(this%ed_parsha_z(ncan,numpft,nveg))
allocate(this%ed_laisun_z(ncan,numpft,nveg))
Expand All @@ -393,8 +393,8 @@ subroutine NanDynamics(this)
this%tlai_profile(:,:,:) = nan
this%tsai_profile(:,:,:) = nan
this%canopy_area_profile(:,:,:) = nan
this%nrmlzd_parprof_pft_dir_z(:,:,:,:) = nan
this%nrmlzd_parprof_pft_dif_z(:,:,:,:) = nan
this%nrmlzd_parprof_pft_dir_z(:,:,:) = nan
this%nrmlzd_parprof_pft_dif_z(:,:,:) = nan

this%fabd_sun_z(:,:,:) = nan
this%fabd_sha_z(:,:,:) = nan
Expand Down Expand Up @@ -521,8 +521,8 @@ subroutine ZeroDynamics(this)
this%fabi_sun_z(:,:,:) = 0._r8
this%fabd_sha_z(:,:,:) = 0._r8
this%fabi_sha_z(:,:,:) = 0._r8
this%nrmlzd_parprof_pft_dir_z(:,:,:,:) = 0._r8
this%nrmlzd_parprof_pft_dif_z(:,:,:,:) = 0._r8
this%nrmlzd_parprof_pft_dir_z(:,:,:) = 0._r8
this%nrmlzd_parprof_pft_dif_z(:,:,:) = 0._r8

! Added
this%elai_profile(:,:,:) = 0._r8
Expand Down Expand Up @@ -562,13 +562,13 @@ subroutine ZeroValues(this)
this%c_lblayer = 0.0_r8

! RADIATION
this%rad_error(:) = 0.0_r8
this%tr_soil_dir_dif(:) = 0.0_r8
this%fab(:) = 0.0_r8
this%fabi(:) = 0.0_r8
this%fabd(:) = 0.0_r8
this%sabs_dir(:) = 0.0_r8
this%sabs_dif(:) = 0.0_r8
this%rad_error(:) = hlm_hio_ignore_value

! ROOTS
this%btran_ft(:) = 0.0_r8
Expand Down
Loading