Skip to content

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented May 14, 2025

Description:

This pull request calculates summary variables for transpiration wetness factor (btran), which will be eventually used by drought deciduous as part of the updates to the phenology code (#1385). This builds on the running average structures that @rgknox implemented in #724, but now can be used to report the minimum and maximum values for variables using fixed moving average windows (as opposed to exponential moving averages). This is also a follow-up on issue #1408.

The rationale for this is that the mean daily btran may not be the best metric for tracking stress, especially if it varies markedly during the day (which I imagine is the case when FATES-Hydro is on). With this approach, we can use the minimum daily values, and this should provide a more robust way to compare with the values likely to trigger hydraulic failure mortality. Minimum and maximum daily values may be useful for other variables, applications or diagnostics too, and the implemented code can be readily used for other variables.

I did not implement the feature in exponential moving averages because I don't think it would make sense, but happy to modify it if anyone thinks otherwise or has some ideas on how to do it neatly.

Collaborators:

Expectation of Answer Changes:

In the process of implementing the code, I saw one minor, likely benign bug in FatesRestartInterfaceMod.F90 for variable 'fates_disturbance_rates', which was using the sub-routine for running averages instead of the regular one. I edited that, and it could impact the results. If this was my misunderstanding, I am happy to revert it. Otherwise, this should be bit-for-bit except for the new output variables.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

mpaiao added 4 commits May 13, 2025 17:16
…tracking minima and

maxima of fixed window period. This still needs testing.
…d the need of commits

to the host land models. This version successfully compiles, I will test if they run...
@mpaiao mpaiao changed the title Add summary metrics for btran Add summary metrics for btran (and expand capability of running averages) May 14, 2025
@glemieux glemieux requested a review from rgknox May 19, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Finding Reviewers
Development

Successfully merging this pull request may close these issues.

2 participants