Add summary metrics for btran (and expand capability of running averages) #1409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request calculates summary variables for transpiration wetness factor (btran), which will be eventually used by drought deciduous as part of the updates to the phenology code (#1385). This builds on the running average structures that @rgknox implemented in #724, but now can be used to report the minimum and maximum values for variables using fixed moving average windows (as opposed to exponential moving averages). This is also a follow-up on issue #1408.
The rationale for this is that the mean daily btran may not be the best metric for tracking stress, especially if it varies markedly during the day (which I imagine is the case when FATES-Hydro is on). With this approach, we can use the minimum daily values, and this should provide a more robust way to compare with the values likely to trigger hydraulic failure mortality. Minimum and maximum daily values may be useful for other variables, applications or diagnostics too, and the implemented code can be readily used for other variables.
I did not implement the feature in exponential moving averages because I don't think it would make sense, but happy to modify it if anyone thinks otherwise or has some ideas on how to do it neatly.
Collaborators:
Expectation of Answer Changes:
In the process of implementing the code, I saw one minor, likely benign bug in
FatesRestartInterfaceMod.F90
for variable'fates_disturbance_rates'
, which was using the sub-routine for running averages instead of the regular one. I edited that, and it could impact the results. If this was my misunderstanding, I am happy to revert it. Otherwise, this should be bit-for-bit except for the new output variables.Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: