Btran (of fmc) based drought deciduous phenology thresholds #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values used by phenology from phenology. This will help to modularise the code, and allow other parts of the code to use these averages.
…ne with more recent versions of FATES.
…to the existing module.
…ogy to become PFT-specific. In the next commit, several cold-deciduous parameters will become PFT- specific parameters too.
…asonal (cold) deciduous into PFT-specific. This allows different cold-deciduous PFTs to have different thresholds.
…om EDParamsMod.F90
…y both cold deciduous and drought deciduous.
…ngle, multi-option flag. This change simplifies the PFT set up and by default resolves possible incorrect settings of 3 mutually exclusive flags. Some of the associated code was also updated from if statements to select case, to ensure that options do not overlap.
…le phenology parameter.
…at making the code a bit simpler. This is not intended to be bit-for-bit, because some of the changes impact the logic. However, the results shouldn't be dramatically different. 1. Moved the updates for days since last flushing and abscission events to the cumulative time subroutine. 2. Changed the initialisation of the dates of the last flushing/abscission deciduous events, so they can start at negative values. This change should eliminate the need for a few "if" statements in the main phenology subroutine. 3. Added a fourth case for cold deciduous phenology, which forces leaf flushing if plants remain dormant due to cold for a very long time. This should cause these plants to be vulnerable to frost in climates that are too cold for them to survive. 4. Saved some phenology transition tests to logical variables to make the code a bit more readable. 5. Restructured the cold-deciduous phenology code so the different checks are inside an if/elseif/else block (so only one change can happen at any time). 6. Replaced some additional checks for growing degree days that should be taken care by change 2 plus the definition of a growing season
…hat happened, but maybe this was a rebase issue.
…tracking minima and maxima of fixed window period. This still needs testing.
…d the need of commits to the host land models. This version successfully compiles, I will test if they run...
…is the list of changes: 1. The threshold parameter names are the same as before, but they now changed meaning. If they are positive, the threshold is interpreted in terms of water availability expressed as 10-day btran running averages (minimum daily values). This makes the coordinated configuration of phenology and hydraulic failure mortality simpler. 2. If the parameters are negative, the threshold is still the same as before (mean soil matric potential of the rooting zone), but this is now deprecated and may be removed in the future (or in the present, if others think it is fine to remove it). 3. The code now compares the FATES parameters to see if the values can create hydraulic failure mortality before leaf abscission. If this happens, the code issues warnings. 4. The fates_params_default values are first guesses of this new configuration. This will be eventually updated with fitted/optimised values.
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
mpaiao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit is part of the task #1385. This code revises the drought deciduous phenology thresholds, by using the 10-day average of the daily minimum transpiration wetness index (also know as btran) as the water stress metric. This (hopefully) allows ensuring that the parameters that drive hydraulic failure mortality and drought deciduous phenology are in the same units, which reduces the risk of drought deciduous hydraulic failure mortality due to inconsistent parameters (see #1363 for more insights). Note that this should work with FATES-Hydro disabled or enabled. In case FATES-Hydro is enabled, btran is defined in terms of fraction of maximum conductivity (also known as fmc).
This is the list of changes:
This pull request is built on top of #1389, #1392, #1409 and #1396, so it is better to merge this only after the other pull requests are merged.
Collaborators:
@rosiealice @glemieux @rgknox @ckoven
Expectation of Answer Changes:
This is an update on how we define abscission/flushing thresholds for drought deciduous, and results are expected to change if drought deciduous PFTs are present.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: