Skip to content

Refactor API boundary condition passing mechanism #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 110 commits into
base: main
Choose a base branch
from
Draft

Refactor API boundary condition passing mechanism #1431

wants to merge 110 commits into from

Conversation

glemieux
Copy link
Contributor

Description:

WIP - DO NOT REVIEW. FORCE PUSHES LIKELY.

Collaborators:

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added the status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration. label Jun 30, 2025
glemieux added 20 commits July 2, 2025 09:28
@glemieux
Merge tag 'sci.1.85.3_api.40.0.0' into bc-refactor-patch-direct
8d19797 
Seed localization for no competition

This update ensures that seeds will end up only on patches of the same
pft during the seed update
@glemieux
Merge remote-tracking branch 'glemieux/bcinout-argument-old' into bc-…
2fdaf10 
…refactor-patch-direct
@glemieux
remove unused bc_out from init_site_vars
5ab259a
@glemieux
remove unnecessary bc_in argument from canopy_summarization
3b5c629
@glemieux
remove unnecessary bc_out argument for accumulatefluxes_ed
fc61230
@glemieux
Merge tag 'sci.1.86.0_api.40.0.0' into bc-refactor-patch-direct
d6fe4e2 
Add bc_out variables for HLM stock and flux calculations

This allows the HLMs to calculate NBP and TOTECOSYS
@glemieux
fix interface for module procedures
b9b40ac
@glemieux
correct do while statement
62794b2
@glemieux
correct select case and younger patch association
f80185c
@glemieux
add missing end subroutine statment
3424c91
@glemieux
temporarily comment out the 3d option
dedfd4a
@glemieux
add site-level mapping vectors
8307ca6
@glemieux
fix incorrect index definition
1f11e96
@glemieux
move BC transfer procedure from interface mod to site as type-bound p…
a163f0a 
…rocedure
@glemieux
make generic procedure for transferbcin subroutine
cca0a5d
@glemieux
minor cleanup
549a590
@glemieux
Merge tag 'sci.1.86.3_api.40.0.0_tools.3.1.0' into bc-refactor-patch-…
f2f489d 
…direct

Testing improvements to enable ctsm system testing
@glemieux
initial handover from site-level bc_in to patch level bc_in for fragm…
57a43e2 
…entation scalar only
@glemieux
remove w and t scalars from interface bc init procedures
cefd2d1
@glemieux
add decomposition temperature limitation to transfer in
29f586b
@glemieux
Copy link
Contributor Author

glemieux commented Aug 1, 2025 •
edited
Loading

Tasks todo:

  • Remove unused bc variables found
  • Add bc_out transfer mechanism

@glemieux
update the api registration procedure to pass in the subgrid index fo…
e990d4c 
…r the given variable
@glemieux
implement the updated api registry assignment of the column index
f08972a
@glemieux
whitespace
76f9bd7
@glemieux
adding comments and whitespace adjustments
9958416
@glemieux
update the registry initialization to reflect the change to the subgr…
0d95ee2 
…id index information
@glemieux
add missing rank update
1d5878f
@glemieux
add case select logic and pointers to index into the source data pointer
cff1e3b
@glemieux
add type-safe selection constructs to the update interface variable p…
d89ae39 
…rocedure
@glemieux
move subgrid heirarchy values into fates interface types mod
5d62969
@glemieux
remove superseded transfer bc procedures
1ead812
@glemieux
add intent in to all registry subroutines
1746c0c
@glemieux
remove defunct transferbcin/out procedures in patch type
bf6999f
@glemieux
add data size to the var type
0792e90
@glemieux
add dimension error diagnostics to the var type
6bbce25
@glemieux
convert variable size comparison error checking to a subroutine
1420ec3
@glemieux
add scalar interface register subroutine
9f098a5
@glemieux
add nlevsoil to patch-level bcin
6883050
@glemieux
add interface key names as parameter variables
203d584
@glemieux
move subgrid index types into fatesinterfacetypesmod
6cbc783
@glemieux
move patch_api pointer update inside the do while
68ff7a8
@glemieux
todo comment updates
28f629e
@glemieux
removed unused indexers
274c6fe
@glemieux
Correct which api has the subgrid indice update.
65d967b 
Technically we don't really need a subgrid_indices array for the patch-side currently.
@glemieux
adding comments for next steps
64128ba
@glemieux
add update frequency to the registry variable type and and counters t…
c4956f2 
…o the api registry type

This will help next development steps in which the update of certain variables will be conducted prior to others
@glemieux
add filters to the registry api type to provide shorter loops during …
f33b34b 
…update calls
@glemieux
update the definteinterface call to pass initialization update freque…
849b23d 
…ncy for the soil level
@glemieux
minor formatting changes
8d191e6
@glemieux
initialize local variable to avoid implicit save
d7ca3f8
@glemieux
add registry procedure to update on the variables during initialization
b49b055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration.
Projects
FATES Pull Request Planning and Status
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glemieux