-
Notifications
You must be signed in to change notification settings - Fork 103
2025 Software Engineering meeting notes
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- FATES NN Emulation of Photosynthesis
- Ryan: do_alb pull request is on a pathway to completion
-
FATES modeling meeting: 25 September, TBD
- We will run office hours
Integrated (or waiting)
- FATES API 41 updates (#7665): Testing complete. Waiting on e3sm integrator.
Testing
- Removing non doalb call of wrap_canopy_radiation for fates (ctsm#3051)
- gpp_site restart fix (#1448): Testing complete. New exact restart issue discovered in elm-fates logging.
Hold
- Add NBP, TOTECOSYSC, and related summary variables for FATES configurations (#7231): Waiting on #1448 integration. Also needs rebasing against master once e3sm#7665 is integrated
Latest issues and discussions of note
Issues
- Create checks on fates_leaf_fnps (#1468): Feature request to address #1462
- Unexpected diffs in RH among patches at a single site (#1469)
- site%rxfire_area_f* variables never initialized (#1470)
- Discuss who will review Charlie's PR at the CTSM SE meeting
- deferred
- Ryan: presented progress update on neural network fates
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- FATES modeling meeting: 25 September, Sam Rabin, forest edge effect
Testing
- Removing non doalb call of wrap_canopy_radiation for fates (ctsm#3051): Ready for final ctsm aux_clm tests
Review
- gpp_site restart fix (#1448): Needs final review
- radiation refactors - rad_error and rad profile diagnostics (#1397): Ready for review.
- FATES API 41 updates (#7665): Ready for review.
Latest issues and discussions of note
Discussions
Issues
-
Max Btran Value Eqaul to 0.8 in Static Structure Mode (#1461)
- Waiting on the
- CiBisection error (#1462)
- Why are bc_in%pop_density and lightning24 per-patch (#1464)
- UpdateRxfireBurnWindow and update_nesterov_index() comments have wrong wind units? (#1465)
-
Define Supported FATES Compsets for CLM6 Release (ctsm#3101)
- Charlie created a land use data tool PR to generate steady-state land use for
I1850Clm60FatesNoCompFbg
andI2000Clm60FatesNoCompFbg
compsets
- Charlie created a land use data tool PR to generate steady-state land use for
- Adrianna: Running simulations in which FATES adopts some CLM parameters (e.g.
fff
)- Running stomatal conductance with BTRAN calculated in a similar manner to CLM
- Jessie: reviewed TRENDY results with NorESM-FATES with Rosie and Chetel and talking about next steps in calibration
- Charlie: shared initial ILAMB benchmarks from TRENDY
- HLM-FATES showing spatial biases in the tropics biomass
- Jessie: Some of the benchmark performance biases could be related to coarser resolution compared to other models
- Will: share this at CLM or FATES modeling meetings
- Discussing meeting coordiation with NorESM folks
- Ryan offered to attend NorESM meetings.
- Jessie to discuss with Rosie
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- CLM-FATES one-at-a-time diagram
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- Jessie is back!
- FATES modeling meeting: 11 September, TBD
Integrated
Stuck
- L2FR and c-only Spinups: Bharat reported back that he's not seeing the results he's expecting. Anthony and Ryan working to help determine why. Possibly due to a seperate issue?
- E3SM - TOTNBP : Greg and Ryan to have a working meeting this week. Plan is to create an issue and intergrate this if they can't come up with a fix this week since it only affects the first model-timestep after restart and does not propogate (i.e. all other timesteps are b4b).
Review
- Do-alb and radiation: Ryan continuing to work on this.
New
- FATES API 41 updates (#7665): Ready for review.
Latest issues and discussions of note
- "isnew" and the intersection of hi-frequency flux diagnostics and growth respiration (#1453)
- Add graceful fails to prevent P-coupling with CLM (#1454)
- Incorrectly grouped history variables (#1455)
- Inconsistency in longitude format for inventory(#1457)
- Update BCI patch-file name (#1458)
- consistency with fates_history_dimlevel NL settings (#1460)
- Discussed final list of compsets last week: https://github.com/ESCOMP/CTSM/issues/3101#issuecomment-3254638769
Cancelled due to Federal Holiday
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- Charlie: TRENDY results are being processed, seeing boreal cold bias, possibly due to low productivity Rosie was seeing
- Ryan: Getting FTorch working and
- E3SM All-Hands: 25-29 August
-
FATES modeling meeting: 28 August, TBD
- Likely cancel
- Sam Rabin to present in September. Added to the table.
Integrated
- FATES API41: default paramfile update (ctsm#3372): tagged at ctsm5.3.070
Testing
-
promotion/demotion refactor and nclmax = 3 (#1424): testing complete
- Many tests B4B except for dimension length differences
- Removing non doalb call of wrap_canopy_radiation for fates (ctsm#3051): Ryan to test in sp mode per Matvey's request.
Stuck
-
Add NBP, TOTECOSYSC, and related summary variables for FATES configurations (E3SM#7231): failing exact restart for
NEP
,NBP
, andNEE
-
gpp_site restart fix (#1448): Nearly fixes this, but still resulting in restart diff for only the time step after restart. Does not propogate.
- Ryan: Does #7278 contribute to this?
-
gpp_site restart fix (#1448): Nearly fixes this, but still resulting in restart diff for only the time step after restart. Does not propogate.
Review
- radiation refactors - rad_error and rad profile diagnostics (#1397): This is out of hold per fixes to ctsm/#3051 and ready for review
- fixes for history level 1 (#1456): Greg to review next
- Diagnostically track forest edge (#1432): Sam to start building a new branch off of this for science presentation in September. Please let him know if there are any large changes needed sooner rather than later.
Latest issues and discussions of note
- Potential issue in matching model grids and inventory sites when coordinates in different format (#1457)
- Incorrectly grouped history variables (#1455): Ryan to create PR to address this building on top of #1456
To discuss next week:
- "isnew" and the intersection of hi-frequency flux diagnostics and growth respiration (#1453)
- Add graceful fails to prevent P-coupling with CLM (#1454)
- Incorrectly grouped history variables (#1455)
- Support FATES compsets ctsm/#3101 to be reviewed during CTSM software engineering meeting this Thursday
- Rosie: Chetle has nearly finished TRENDY runs
- Aside: Jessie starting next Monday!
- Seed issue seems to be mostly worked out now; working on timestepping issue.
- Charlie: NorESM TRENDY boreal region comparison to ELM-FATES TRENDY runs?
- Rosie: NorESM is a little more productive with new calibrations. SLATOP seems very sensitive.
- Charlie: suggest using alternate initialization to fill area: assume full canopy (
fates_recruit_init_density
with negative number )
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- Charlie: TRENDY results submitted
- Jennifer: Alan is going to be picking up some of Jessie's previous work
- E3SM All-Hands: 25-29 August
-
FATES modeling meeting: 28 August, TBD
- Charlie: Share TRENDY simulation results?
Integrated
- API 41 parameter file merge (#1444), Remove deprecated quadratic smoothing parameters (#1419), change crop PFT back to cool C3 grass (#1412), Prescribed fire implementation (#1360)
Testing
- FATES API41: default paramfile update (ctsm#3372): One test issue to resolve and awaiting review. Sam Rabin looking into issue.
- promotion/demotion refactor and nclmax = 3 (#1424): up next for testing
Stuck
- gpp_site restart fix (#1448): Greg still working on this.
Latest issues and discussions of note
- nutrient balance errors during global historical transient runs (#1451): Failed during end of run, Charlie investigating.
-
patch-too-small error during global transient historical run (#1452): Edge case for predominantly rangeland? Threshold may be too conservative.
- Commenting out the error results int
To discuss next week:
- "isnew" and the intersection of hi-frequency flux diagnostics and growth respiration (#1453)
- Add graceful fails to prevent P-coupling with CLM (#1454)
- Incorrectly grouped history variables (#1455)
- CTSM team to schedule meeting to discuss next steps for CLM6 fates supported compsets
- Rosie: NBP not hitting zero?
- Charlie/Adrianna: try adjusting seed rain
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- Machine Learning Update (5 min)
- Ryan: 500 pull requests closed!
- Charlie: TRENDY simulations complete
- Greg: Alternate attempt at fortran unit testing working well (so far)
-
FATES modeling meeting: 14 August, TBD
- Adam invite update?
- Ryan: Reach out to Dennis about JAX?
- Charlie: Carl Steefel on paper as well.
- Charlie will cancel meeting
Testing
-
Prescribed fire implementation (#1360): Final testing in progress, new testmods added.
- FATES API40.1: default paramfile update (ctsm#3372): To be updated soon. Needs review.
Stuck
-
Add NBP, TOTECOSYSC, and related summary variables for FATES configurations (E3SM#7231): failing exact restart for
NEP
,NBP
, andNEE
-
gpp_site restart fix (#1448)
- Drafted as potential fix, but seeing unexpected
NaN
s post restart timestep.
- Drafted as potential fix, but seeing unexpected
-
gpp_site restart fix (#1448)
Review
- promotion/demotion refactor and nclmax = 3 (#1424)
- Adding nutrient supplementation status to arguments in FATES dyanamics (#7542): Bharat reviewing
-
Diagnostically track forest edge (#1432): reminder to review
- Eva's checked out a branch that likely has nocomp on by default
Future
- Development of CTSM-FATES nutrients
- Ryan: met with Sam Levis. It looks like the updates things should be straightforward, as only one demand scheme in ctsm compared to e3sm.
Latest issues and discussions of note
- error during restart in surfrd_veg_all (#1446) : non-reproducible issue?
- unexpected PFT coexistence / tropical trees in alpine site? (#1450): Rosie has responded with potential answer
- Define Supported FATES Compsets for CLM6 Release (#3101): status update set for CTSM SE meeting this Thursday
- Rosie: Attempting to keep boreal forest from dying when seed rain is off
- Should the carbon starvation scalar be smaller? Rosie running some tests.
- Rosie: More snow with fates on than with clm. Will reach out to Adrianna about relevant parameters.
- Charlie: potentially topographic issue given differences seen in Russian lowlands?
- Rosie: suspicion is that snow burial is different between the two models.
- Rosie: 2deg PPE kickoff today
- Charlie: TRENDY results
- "Control" case still showing low frequency variation over time. Possibly due to landuse secondarylands harvesting threshold? Charlie setting up a no logging test case.
- Working on converting results to TRENDY format
- deferred
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- Machine Learning Update (5 min)
- Fire model update (10 min)
-
FATES modeling meeting: 14 August, TBD
- Charlie to reach out to Adam about his recent paper
Review
-
supplementation constraints on dynamic L2FR with CNP (#1443): Based on and supersedes #1353
- Adding nutrient supplementation status to arguments in FATES dyanamics (#7542): e3sm-side companion PR
- Pass nutrient supplementation status to FATES (ctsm#3348)
- Charlie: may not be fully pathological based on current TRENDY results
- Should this be an option? Unsure.
Testing
-
Add NBP, TOTECOSYSC, and related summary variables for FATES configurations (E3SM#7231)
- Rosie working on the NorESM side of this. No conceptual differences in the way this is being handled across HLMs.
- Balance check reconciliation discussion
- Need a virtual pool of the fluxes. "Smear" out the fluxes out over the day to avoid things like fire emissions happening at the same time each day.
- Rosie to share diagram af concept of the issue
- Charlie: ELM product carbon loss flux as at the column-level, not the gridcell level
- Charlie: 50-year global periodicity seen in spin-up (offline). May not be issue, but investigation underway.
-
Prescribed fire implementation (#1360): testing now, ran into some build issues
- FATES API40.1: default paramfile update (ctsm#3372): transfered parameter switch to namelist option
Latest issues and discussions of note
-
How to implement a manual static model by disabling growth (#1445)
- Charlie: we can calculate the delta 13 C of GPP (Chonggang implemented), but other than that, this would be a new capability.
- Charlie to respond.
- Charlie: we can calculate the delta 13 C of GPP (Chonggang implemented), but other than that, this would be a new capability.
-
Completing the FATES-CLM nitrogen coupling #3378: Sam Levis working on nutrient coupling with FATES
- Should work with MIMICS and regular CLM nutrients
- Ryan to get back to discussing doalb with Matvey now that he's back.
- Adrianna: Discuss CLM compsets items at Thursday meeting
- Adrianna: CLM vs FATES vcmax parameters discussion
- FATES is higher than CLM, but levels off with increasing temperature
- Rosie: Martijn Slot (NGEET) has a paper that has looked at this
- Adrianna: Little change in GPP with
fates_rad_leaf_rholvis
increase?- Marcos: related to leaf temperature?
- Ryan: stronger SLA response?
- Rosie: less light getting through to the soil?
- Rosie: FYI mini-NorESM coupled concentration PPE upcoming
- deferred
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status (1 min)
- Calibration update (10 min)
- Fire model update (10 min)
- NBP not equalling delta TOTECOSYSC (or sum of other C fluxes) during trendy spinup (5 mins?)
- FATES modeling meeting: 31 July, TBD
Integrated
Testing
- Add NBP, TOTECOSYSC, and related summary variables for FATES configurations (E3SM#7231)
- Prescribed fire implementation (#1360)
New
-
supplementation constraints on dynamic L2FR with CNP (#1443): Based on and supersedes #1353
- Adding nutrient supplementation status to arguments in FATES dyanamics (#7542): e3sm-side companion PR
Latest issues and discussions of note
- No new issues or discussions
- Starting one-at-a-time calibration paper
- Related: NGEET landuse meeting last week: Xiuyi Wu using FATES at Tanguro to engage with edge-effects code
- No long-term systematic trend in NBP seen during spin up
- NPP-based NBP not matching GPP-AR based NBP very slightly different; potentially a time-stepping issue?
- Hypothesis: model is conserving carbon, but diagnostic output is missing a term (or double counting one)
- No obvious single candidate
- Doesn't seem to be an area difference
- Charlie is using Rosie's previous calibration cases
- TL;DR hold off on integrating NBP pull requests
- Additionally: seeing lots of CWD carbon, little soil carbon.
- FATES is not the only model like this, but this points to nocomp calibration necessary
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (10 min)
- FATES-CLM6 Code freeze status
- Calibration update (10 min)
- Fire model update (10 min)
- Ryan: apprecation for colleagues
-
FATES modeling meeting: 31 July, TBD
- Marcos to check in with Danyang soon.
- Ryan and Marcos are
- Marcos: Yixin Ma has ED2 paper pubished recently
- CLM meeting: 22 July, Sean Swenson, spatially-explicit PFTs
Integrated
-
NBP fates side updates in final testing,
Remove unnecessary
bc
argument passing (#1414), Fixes to vegc canlayer diagnostics #1438, remove trunk_product_site variable (#1433)
Updates
- Unit/functional test improvements to enable CTSM SystemTests (#1426): Greg ran into an issue trying a simle implementation test (see issue #1441 below)
- dynamic L2FR (#1353): Ryan will work on this to avoid it going stale. Also see walk on discussion below.
Ready for Review
- Diagnostically track forest edge (#1432): Adrianna to be tagged for unit testing review. Marcos and Charlie to review the rest.
Latest issues and discussions of note
-
Methods (eventually?) needed to deallocate all parameter-related arrays (#1440)
- Consensus is to move PRT params back to the main param type
-
unit and functional testing fail to run on derecho (#1441)
- Greg to attempt running on a fresh checkout. Also try running with associated CTSM PR (#3251)
- Progress review shows that we are on track.
- No new discussion outside of forest edge tracking
- Ryan: nutrient development branch?
- Will: concerned about divergence of branches. Notes the Sam Levis will be working on bringing FATES nutrients to CLM in the near future.
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- FATES-CLM6 Code freeze status
- Calibration update (10 min)
- Fire model update
- FATES modeling meeting: 17 July, Adrianna Foster, User-defined PFTs
New
- Fixes to vegc canlayer diagnostics #1438: Approved, in testing queue
Updated
-
promotion/demotion refactor and nclmax = 3 (#1424): Greg reviewing
- Hold a PR walkthrough meeting?
- remove trunk_product_site variable (#1433): Approved, in testing queue
Latest issues and discussions of note
- Deferred, no new updates. NBP is next relavent item.
- Continent specific allometries
- Comparison to GEDI: patchy differences
- Using crown area weighted height as comparison metric
- Jessie using newer product in which aggregation is already handled
- Marcos: check to see what GEDI uses for height
- Recommends using rh-98 as opposed to rh-95
- Charlie: create new diagnostic output for better comparison?
- Related: May need similar new output for TRENDY comparison
- FATES continental to pantropical PFT comparison: subtle differences
- Comparison to GEDI: patchy differences
- Diagnostic edge forest PR is close to done
- Still need to look at scientific results
- Review request: Charlie and Marcos
- Jessie: Spatially-explicit PFT Parameters (Adrianna's email)
- Sean Swenson working on this using FATES
- Goal: Much more finely resolved spatial variation
- Implementation detail still TBD
- Invite Sean to the FATES meeting for a presentation? Discuss in the email thread.
- Ryan: do we want the e-factor to be temporally varying as well?
- Related: Elyas discussion
- Ryan: NESAP proposal with Damian Rousson (CLaSS group lead) to use fiats for FATES photosynthesis emulation
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- FATES-CLM6 Code freeze status
- Latest issues (5 min)
- Calibration update (10 min)
New
Updated
- Deferred, no new updates. NBP is next relavent item.
Latest issues and discussions of note
-
Remove unused turgor loss point parameter
- Chongang confirmed this is expected
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- FATES-CLM6 Code freeze status
- Latest issues (5 min)
- Solar diffuse radiation in CLM
- Calibration update (10 min)
- Fire model update
-
FATES modeling meeting: 3 July, Jenny Kowalczyck
- Charlie: Jenny confirmed
- Marcos added as future TBD
Merged Recently
- PR Template Update protecting SP
- Nocomp Seed Localization
- Have external seed rain only fall on a given PFT's nocomp patches
New
-
Unit/functional test improvements to enable CTSM SystemTests (#1426)
- wget downloading from drop box currently and functionality is working, but we really should install git LFS
- ctsm uses LFS for images and testing files only
- Charlie: put these in ctsm?
- Adrianna: keeping tests and necessary files located with the repo is preferred. Reduces workflow update complication.
- Our "grandfathered" plan doesn't have a free git LFS allocation. Greg to check if we can just install it or if we need to add money to the budget.
- Ryan: maybe we could use this to hold parameter netcdf files :thinking_face
- Plan B: load the file to a "testing" directory on the CESM input data svn repo
- wget downloading from drop box currently and functionality is working, but we really should install git LFS
-
Updates to hydraulic failure mortality (#1427): imposes consistency between hydro and non-hydro run modes
- Condenses two parameters into a new single parameter
- Ask Chonggang or Jenny for review
- This should accompany an update to the technical documentation
- This shouldn't affect SP mode, but will likely affect no-comp
Updated
- NBP fates side updates in final testing: Ready for testing
- Unnecessary bc in final testing: Ready for testing
-
Removing smoothing parameter in final testing: Ready for testing, to be integrated with other parameter pull request updates
- ETA is 3 weeks due to other priorities and vacations
- nclmax=3: Ryan running testing, but looking for reviewers
- Deferred, no new updates. NBP is next relavent item.
Latest issues and discussions of note
-
Remove unused turgor loss point parameter
- Should this be used, was it an oversight? This is a commonly available observed trait.
- This might be a good discussion point in the modeling meeting
- Adrianna: default CLM-DATM allows model to determine diffuse or direct, but for TRENDY we need to run both explicitly
- Charlie: Does this capability exist in ELM?
- Reach out to Xiaojuan Yang who has been doing TRENDY runs with ELM
- Charlie: Does this capability exist in ELM?
- Adrianna: calibration algorithm is in the works. Was written in tensorflow, but changing to scipy.
- Issue: Want to be able to hold certain paramater values static during investigation which turns out to be very difficult to do tensorflow.
- Edge forest branch up-to-date with latest fates tag
- Purely diagnostic output currently
- Working on unit testing
- Sam to draft a pull request
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- FATES-CLM6 Code freeze status
- Latest issues (5 min)
- Calibration update (10 min)
- Fire model update
- FATES modeling meeting: 3 July, Jenny Kowalczyck
Integrated
Testing
- Nocomp seed localization (#1371): Charlie approved updates. Greg testing.
- Prescribed fire implementation (#1360): Greg deconflicted. In testing queue. Requires default parameter file update.
Updates
- Removing non doalb call of wrap_canopy_radiation for fates: Ryan working to clarify issues that Matvey is seeing this week.
-
Add variables needed for NBP and TOTECOSYSC to bc_out structure,Add NBP, TOTECOSYSC, and related summary variables for FATES configurations
- Greg sent Rosie an email to get input on bringing NorESM/ctsm PR back to origin
- elm, understanding components of column level summary stocks: Ryan created to get clarification.
-
nclmax=3
- Comparison against 2 canopy layers (baseline)
- Higher stomatal conductance, veg carbon is kind of a wash.
- (Jennifer) Trimming dynamics with 3 layers?
- (Jessica) Related: Seed germination rate is too high in default and has been a problem. Order of mag lower?
- Comparison against 2 canopy layers (baseline)
New
-
Parameter File Tool repo: drafted
- Concern: decentralization will require duplication of code (testing or shared utilities) among test
- Consensus: Don't separate out the tools into separate repositories. Condense landusedata and other fates tools into the same tool repository.
Latest issues and discussions of note
- No new issues
- (Charlie) Tool issue forthcoming
- Edge area diagnostics added. New testing.
- Timeline: Merge this into main branch soon?
- Will include a feature switch
- More updates
- (Ryan) Trimming code update to include more terms
- Will not impact sp mode
- (Adrianna) SP mode calibration simulations running
- (Charlie) TRENDY forcing file update?
- Adrianna: waiting a week to find issues in the file
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- FATES-CLM6 Code freeze status
- Moss model integration discussion
- Latest issues (5 min)
- Calibration update (10 min)
- FATES modeling meeting: 3 July, Jenny Kowalczyck
- Handover/Offboarding meeting planning
- No comp calibration: Jessie to look at the week of June 24
- Phenology updates: Greg and Ryan to coordinate
- Party: Thursday June 26
Integrated
Under Review
-
Add variables needed for NBP and TOTECOSYSC to bc_out structure (#1382): Ryan created PR to this branch.
- Add NBP, TOTECOSYSC, and related summary variables for FATES configurations (E3SM#7231)
- NBP outputs (NorESMhub/CTSM#137): Matvey started reviewing last week. Check in on timing of PR back to ESCOMP with Rosie.
-
Prescribed fire implementation (#1360): Sam has re-reviewed and Xiulin has implemented recommended fixes.
- Greg to deconflict against
main
which now includes the SPITFIRE mortality refactor
- Greg to deconflict against
- Nocomp seed localization (#1371): Greg merged #1415 and reconciled differences. Needs validation from Charlie.
New
- Event based logging mortality fix #1422
- Fix some bugs in testing #1423
- promotion/demotion refactor and nclmax = 3 #1424
- SP mode tag freeze
- Related: Charlie is tentatively planning on runngin TRENDY. Coordination?
- Adrianna is running TRENDY for bigleaf. She'll share the driver data and other common scripts, etc.
- Driver data is identical
- Q: what resolution? 0.5 deg? Still TBD.
- Adrianna is running TRENDY for bigleaf. She'll share the driver data and other common scripts, etc.
- Related: Charlie is tentatively planning on runngin TRENDY. Coordination?
- CESM3 answer changing freeze has shifted to November
- Foster et al. (2019, Ecological Modelling)
- Hansen, Foster, et al. (2023, GMD)
- Software design doc
- samsrabin/fates PR #2: [WIP] Moss
General idea: Moss has some maximum photosynthetic rate that is reduced by multiplicative factors representing light and moisture availability. Moss layer can build up over time and contributes to fuel. We'd like to have at least two moss PFTs that have different "preferences" regarding shade. Stretch goals include (a) nitrogen limitation, (b) effects of moss on tree regeneration.
Major questions:
- How to handle water (interception, limitation)? BTRAN doesn't really work because it's all about roots, which mosses don't have. Will check if LiBry can offer anything here.
- How to handle fraction area coverage: Assume 100%? Treat like grass? 100% assumption complicates comparisons with observations, which are mostly just % cover (not biomass).
Followup
Hui Tang's work?
- Slides
- Personal FATES fork
- Recommendation: Reach out to Rosie about this
Latest issues and discussions of note
- No major issues to discuss
- No updates
- Marcos: simplifying the hydraulic mortality parameters to a single parameter
- The formulation between fates hydro on is different from hydro off; Is this what we want?
- Off: step function, not linear.
- The formulation between fates hydro on is different from hydro off; Is this what we want?
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- FATES-CLM6 Code freeze status
- Latest issues (5 min)
- Calibration update (10 min)
- Acknowledging efforts of the calibration team
-
FATES modeling meeting: TBD, Jenny Kowalczyck
- Other future talks?
- (Ryan) Nick Smith, Trevor Keenan?
- Jennifer to check in with Trevor about the GEE-FATES work
- (Greg) Pierre Gentine presented differentiable land mode at GEWEX ML4LM (advertised by ILMF newlist)
- Julian Lamour about JB implementation?
- Other future talks?
- Marcos: More european FATES users (e.g. Ghent); should we revisit the meeting times for various meetings?
- (Greg) Rosie's CET meeting still going?
- (Ryan) Survey FATES users?
Testing
-
Add Johnson and Berry 2021 electron transport model option (#1350): Ready for regression testing. Gives answers that are just as sensible as FvCB in this notebook
- Ryan: technote update? Jessie: Julien provided PDF explainer.
- Prescribed fire implementation (#1360): Greg deconflicting against recent history refactor. Adrianna and Sam R to approve.
- change crop PFT back to cool C3 grass (#1412): Test independently and merge into #1360
Stuck
- increase ncl max from 2 to 3 (#1315): Ryan working on addressing promotion edge case
Under review
-
Add variables needed for NBP and TOTECOSYSC to bc_out structure (#1382): Ryan reviewed. To discuss.
- Add NBP, TOTECOSYSC, and related summary variables for FATES configurations (E3SM#7231)
- NBP outputs (NorESMhub/CTSM#137): Will Rosie/Matvey create PR to ESCOMP?
- Nocomp seed localization (#1371): To be approved soon.
- radiation refactors - rad_error and rad profile diagnostics (#1397): Ryan and Matvey having a discussion wrt do_alb pull request.
- Add some biophysical variables by land-use type (#1407): Sam reviewed. Relative location on CLM6 freeze priority queue?
New
- Remove deprecated quadratic smoothing parameters (#1419): simple PR to be merged into #1412 or #
-
Remove unnecessary
bc
argument passing (#1414): New simple b4b PR. -
Btran (of ftc) based drought deciduous phenology thresholds (#1411): Replaced soil moisture threshold with BTRAN
- Motivation: should help address hydraulic failure mortality issue (#1363)
- Ryan: instaneous or smoothed? A: Smoothed.
- This looks bigger than it actually is as it builds on four other PRs
- Seperate PR: reconcile
fates_mort_hf_flc_threshold
andfates_mort_hf_sm_threshold
given #1411 changes? - Future discussion: Get rid of matrix potential options in favor or btran?
Draft
- Crown fire Scott & Reinhardt 2001 (#1362): Xiulin actively working on this
- No updates
Latest issues and discussions of note
- Roundoff error too large when running land use and
ne30
grid (#1417) -
Potential bug in logging model
- Jessie: can make PR that fixes harvest tag, but history variable isn't updating (
hio_m7_si_scpf
)-
lmort_direct
doesn't seemed to be passed to history correctly - Potentially due to
LoggingMortality_frac
- Check in with landuse folks to see if
m7
is reporting non zero for expected logging - Jessie to make a draft PR to handle the harvest tag initialization issue. Add in fix to
lmort_direct
(as needed).
-
- Jessie: can make PR that fixes harvest tag, but history variable isn't updating (
- Allometry discussion (Ryan and Elyas)
- Jessie's continent specific slides
Canceled
Canceled due to Holiday
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- FATES-CLM6 Code freeze status
- Latest issues (5 min)
- Calibration update (10 min)
- NGEE-Tropics Annual Meeting: Wed 21 May
-
FATES modeling meeting: 05 June, Jenny Kowalczyck
- Send out cancellation notice for 22 May
Testing
-
Initializing itype as
spval
for fates patches (CTSM#2935): Ryan testing, next ctsm tag (ctsm5.3.045)- One of our sp mode tests we call the dry deposition scheme, which uses
itypes
, causing test failure - Charlie: which traits?
- Ryan: not sure, Wesley table?
- Rosie: NorESM has an update to directly associate dry dep pfts to fates pfts. Matvey will push that back to ctsm at some point in the future
- Ryan: Create issue to track this and note NorESM update
- One of our sp mode tests we call the dry deposition scheme, which uses
-
use
trim_limit
as floor of trimming (#1395): Approved. In testing queue. Charlie to review one minor question.
On Hold
- API 40 default parameter update (#1406) and Update fates default param (API 40)(CTSM#3087) to be tested once ctsm5.3.045
Stuck
-
dynamic L2FR (#1353): Greg connected with Bharat and got the parameter file he was using to replicate his test case (AD spin up only).
- Pass nutrient supplemenation parameters (E3SM#7182): Has a circular dependency error that needs to be addressed.
- No updates
Latest issues and discussions of note
- Error in logging when restart from previous simulation w/out logging in API37 (#1410)
- Expand
rmean_type
for other aggregation metrics (#1408)
- deferred
- Balance check issue for NBP in CTSM https://github.com/NorESMhub/CTSM/pull/137
- Related: https://github.com/NGEET/fates/pull/1382
- TL;DR fates balance check is daily, but NorESM/CTSM has half-hourly check. Do we need a virtual NPP pool?
- This has implications for AR and fire fluxes as well
- We need to flow chart this out
- Ryan: note that there is interest in NGEET that would provide high-frequency data which they want to represent in the model.
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
- #1252 is in!
- Rosie and Sam R were able to meet IRL last week.
- NGEE-Tropics Annual Meeting: Wed 21 May
- Changed to one day, virtual
-
FATES modeling meeting: 22 May, TBD
- Originally slated to be cancled due to NGEET annual meeting. Reinstate?
- Consensus: leave as canceled
Integrated
- Refactor per-ageclass history (#1252), update AllVars history (CTSM#3058), Electron transport namelist pass fix (CTSM#3063)
On Hold
-
API 40 default parameter update (#1406): "Super" PR. Needs B4B #1355 remote branch merged in.
- Tested #1358 + #1359 parameter updates together. Results approved.
- Update fates default param (API 40)(CTSM#3087) to be updated and coordinated with #1406
-
dynamic L2FR (#1353): waiting on Bharat to re-test with e3sm#7182
- Ryan to make update to facilitate working with ctsm.
- Greg to reach out to Bharat next week if necessary.
- Pass nutrient supplemenation parameters (E3SM#7182): Coordinate with L2F. Ryan to review, low priority.
Testing
-
Initializing itype as
spval
for fates patches (CTSM#2935): Ryan testing, next ctsm tag
Reviews
Prioritization and CLM6 freeze
- On track. Three required pull requests complete.
- Reviewed #817 with Rosie. Agreed that we can close this as this is working in NorESM and CTSM without #817.
Latest issues and discussions of note
-
Biophysical variables by land use type? (#1404)
- Charlie just create Add some biophysical variables by land-use type (#1407) to address this
- Sam R to review.
- Charlie was unsure if the location of the call was ok with everyone.
- Ryan and Greg thinks this is an ok compromise for now.
- Adrianna: CRUJRA versus GSWP3 comparison
- GPP is higher with the former than the latter (was already high with GSWP3)
- Charlie: Used Rosie's parameter file and re-ran some land use cases. C3 grasses is failing (again).
- Charlie is ok with the c3 being overproductive giving that he's enabling grazing.
- Rosie recalls that she was seeing overproductive c3 in tibet. She may have tweaked parameters to suppress this.
- Charlie thinks that he'll need to iterate on this a bit.
- Charlie is ok with the c3 being overproductive giving that he's enabling grazing.
- Rosie: FATES crashing with 2 deg simulations, but not 1 deg sims. Haven't run with this resolution before.
- Matvey thought it may be related to bcleaf being zero?
- Ryan was uncertain about this.
- FYI, Matvey is away this week.
- Matvey thought it may be related to bcleaf being zero?
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- CLM6 Freeze (10 min)
- Calibration update (10 min)
- E3SM API 39
- Adrianna: personally defined PFTs working in nocomp-fbg mode
- Potential presentation at FATES modeling meeting
- FATES modeling meeting: 8 May, Qing Zhu
- NGEE-Tropics Annual Meeting: 20-22 May
- Jennifer: MRV talk tomorrow. Where to advertise?
- Consensus is that its ok for Jennifer to advertise on the FATES modeling meeting list
[PR board status update](https://github.com/orgs/NGEET/projects/13/views/1
Integrated
On Hold
-
Refactor per-ageclass history (#1252): waiting on
ctsm5.3.042
tag completion-
update AllVars history (CTSM#3058) and Electron transport namelist pass fix (CTSM#3063) to come in together as
ctsm5.3.043
-
update AllVars history (CTSM#3058) and Electron transport namelist pass fix (CTSM#3063) to come in together as
Testing
- Leaf phenology parameter simplification (#1355): This should be b4b. Test next without other non-b4b parameter file updates to confirm.
Prioritization
- Ryan: Phenology change priotization relative to the CLM6-FATES code freeze?
- Marcos: The science updates should come in after the code freeze.
-
Facilitate crops in SP mode (#817)
- Adrianna: This should work.
Latest issues and discussions of note
-
Fuel consumed not zeroed when no fire (#1400)
- Adrianna: this will impact diagnostics, but does not actually impact the internal spitfire calculations.
- Should be a simple PR fix, but Xiulin noted there are other spitfire variables that have similar issues. Adrianna asked for list of these to wrap into one PR fix.
- Adrianna: this will impact diagnostics, but does not actually impact the internal spitfire calculations.
- deferred
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
- Ryan: spending hands-on time with OLMT
-
FATES modeling meeting: 8 May, Qing Zhu
- Ryan: Ben Sulman TBD
- NGEE-Tropics Annual Meeting: 20-22 May
Integrated
- trivial radiation transmission fix (#1376), vegetation bin indexing (#1364), leaf sun-shade fraction (#1377)
Testing
- Update to API 39 (E3SM#6918): Waiting on #1376 integration
-
Refactor per-ageclass history (#1252)
- Coordinate with update AllVars history (CTSM#3058)
Reviews
- Electron transport namelist pass fix (CTSM#3063)
-
Prescribed fire (#1360): how to handle parameters?
- Adrianna: Fire development branch?
- Adrianna: how does this comport with Rosie's observed fire work?
- Charlie: very different (Rosie's is more global carbon cycle)
- Consensus is to bring this in as normal
- Coordinate with the eventual parameter file update
Latest issues and discussions of note
-
fates_trim_limit
not enforced (#1393)- Charlie has a quick fix to address this
- Code freeze release date: late summer 2025
- Currently in code "chill"
- B4B changes and parameter file updates for calibration
- Will to send out a meeting invite
- Adrianna: no update
- Jessie and Rosie are out
- Marcos: soil depth discussion
- CLM can define the bedrock depths, but not with ELM
- variable:
zbedrock
- discussion: https://github.com/E3SM-Project/E3SM/discussions/7297
- Marcos to make fates-side discussion
- Marcos to initially hardcode update in ELM to run analysis.
- If analysis shows that this makes a difference, he will
- Ryan: https://github.com/NGEET/fates/issues/732
- Ryan: we should prioritize this
- Greg to test https://github.com/ESCOMP/CTSM/pull/1902
- Katie seems to suggest that this should be working: https://github.com/NGEET/fates/issues/732
- Adrianna: grad student leaf layer cohort question
- Ryan: leaf layers should always start with index 1 for each cohort (the figure provided was incorrect)
- Wins (1 min)
- ESS-PI meeting review
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
- Successful ESS-PI and ESS-CIWG meetings
- Ryan: Debjani Seehee (sp?) biogeochemical cycling work (lack of nutrient mineralize death spirals)
- Jennifer: her U.S. digital soil maps are great
- Jessica: Chongang showed results of stem respiration turned on with fates
- Greg: Root phenology breakout presentation about decoupling root and leaf phenology
- Jennifer: seperate disturbance timescales for above and belowground?
- Ryan: anyone talking with Ben Sulman? Maybe invite him to talk.
- Greg: He gave a lightning version of his ELM-PFLOTRAN alquimia talk
- FATES modeling meeting: Steven de Hertog
- NGEE-Tropics Annual Meeting: 20-22 May
Integrated
Testing
- trivial radiation transmission fix (#1376)
- Update to API 39 (E3SM#6918): Waiting on #1376 integration
- increase ncl max (#1315)
Reviews
- Electron transport namelist pass fix (CTSM#3063): Needs review. To be integrated prior to #1350
-
Prescribed fire (#1360): Sam and Adrianna have reviewed. Xiulin has addressed recommendations. Charlie talked to Xiulin about parameters.
- Concern about brining in all these parameters. What about getting them into a landuse data set?
- Discuss further with Adrianna and Sam
- Refactor per-ageclass history (#1252): Ready for re-review
New
-
Add bc_out vars for HLM NBP and TOTECOSYSC (#1382)
- Corresponding e3sm pr. We need a ctsm version, but this isn't copy/paste due to structural differences.
-
10-day memory migration (#1389): should be b4b
- Didn't incorporate into the running mean module, due to circular reference
-
pft-specific cold deciduous parameters (#1392)
- Charlie: suggest using nans for evergreen
Latest issues and discussions of note
-
canopy sorting problems with nclmax > 2 (#1388)
- Very odd situation in which top two canopy layers were removed. Ryan fixed the logic to make sure that we
- Charlie thinks he might have seen something like this in his sort routine alternate he has initially working on. Charlie likes Ryan's fix better.
-
alternative models for cold deciduos phenology (#1390): consensus is that this would be a good update
- Would be more relvant for someone conducting updates for the boreal region
-
inventory file read error during gridded sim (#1391)
- ED2 fix used a MPI_barrier to avoid this
- Could the issue be the ctrl file itself?
- Switch to netcdf?
- Run restart file and hack the file?
- Related: Yilin to ask Gautam about getting someone to help couple ELM and ParFlow
-
fates_trim_limit
not enforced (#1393): somehow code is allowing trim factors below 30%- Charlie has a quick fix to address this
- Jessie: tropical run with Rosie's parameter file with continent and pft specific allometries
- Ryan: BCI calibration using OLMT on perlmutter
Canceled due to ESS-PI meeting
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
-
FATES modeling meeting: TBD
- Probably make this office hours
Integrated
Testing
- Johnson & Berry electron transpot (#1350): Alistair to review. Greg walked him through the process last week.
- Greg to use his discretion on how to integrate the upcoming parameter file changes
Reviews
-
Prescribed Fire (#1360)
- Ryan: is there another way that we could capture these prescribed parameters?
- Charlie: we could put it on the landuse file or make a specific prescribed fire file
- Consensus is that this might be a good idea as prescribed fire is site/region specific
- Greg: this would require new/updated infrastucture. What does Xiulin's timeline look like; can she wait?
- Charlie: we could put it on the landuse file or make a specific prescribed fire file
- Marcos: combine upper/lower along a fire dimension
- Ryan: Worthwhile to invite Xiulin speak on this? Consensus is yes. Charlie will reach out to her and Lara.
- Ryan: is there another way that we could capture these prescribed parameters?
New
-
Nocomp seed localization (#1371)
- The localization number can be integer for now, but in future for landuse specific nocomp, it should a real number.
Latest issues and discussions of note
-
NEON-FATES-NIWO failing run (ctsm#3038)
- Seeing negative
coszen
value, which is causing crash. Possibly valid coszen due to sun being below zenith if site is on ridge? - Likely due to recent two-stream fix with ctsm5.3.034.
- Seeing negative
-
FATES errsol balance error with cam7 (ctsm#3043)
- Some part of the model thinks that there is no reflected radiation (
fsr = 0
). Likely due to recent two-stream fix with ctsm5.3.034.
- Some part of the model thinks that there is no reflected radiation (
- potential logging bug (#1367)
- change use_fates_potentialveg (#1318)
- Rosie: Working on hand tuning.
- Adrianna: currently working on other deliverables not related to global calibration
- Adrianna: slamax, slatop being the same ok?
- Marcos: this means there will be no plasticity.
- Charlie: Typically for grasses/shrubs
- Marcos: this means there will be no plasticity.
- Rosie: SLA unit conversion sheet and paper results comparison
- Marcos: qualitatively the numbers look correct relative to his recent TRY analysis
- Be mindful of where in the canopy the measurement was made, which can skew results.
- Jennifer: recommending making a synthesis table of all the SLA/LMA results that group has
- Marcos: qualitatively the numbers look correct relative to his recent TRY analysis
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
- FATES-specific surface dataset
-
FATES modeling meeting: TBD
- Qing Zhu moved to later date
- April 10 Eastern regional DVGM overlap.
- Greg to cancel this week.
Integrated
Testing
-
restart fixes for two-stream (#1321): Ryan running final tests
- FATES two-stream restart fixes (ctsm#2949): associated ctsm pull request
- Running into testing issues on izumi. We troubleshot this during standup today. Issue appeared to be license server needing a restart.
- Ryan: clean up misleading text in future PR. Make comment
- Charlie: make two-stream the default?
- Ryan: Conduct a performance test. Greg made an issue #136?
- NCL max (#1315): smoke tests run, but results need review
Reviews
- Johnson & Berry electron transpot (#1350): Greg to reach out to Alistair about reviewing
- Prescribed Fire (#1360): Xiulin has responded to Sam's review notes. Comments need resolving.
- Leaf phenology parameter simplification (#1355): Greg has approved. To be coordinated with other parameter file pull requests.
- Default logging parameters (#1359): reviewer?
- Ryan to double check the age-class comments. DONE. Good to go.
New
- update LUH2 tests (ctsm#3022): simple update to add output to LUH2 tests
- vegetation bin indexing (#1364): discussion with visual aids next week wrt trimming porttion
Latest issues and discussions of note
- Error calculating carbon flux due to fire mortality (#1365): Charlie to review and respond
-
Reconcile parameter and scales driving leaf phenology and mortality (#1363)
- TL;DR: Difference in timescales for hydro mort and enviro mort could result in deciduous pfts dying in conditions that they should be protected against
- From an ideal, simplified case deciduous should be nearly perfectly sheilded from hydraulic failure. Not so for evergreens that can "take more risk."
- Ryan: would it be hard to kill deciduous plants?
- Rosie: Hydraulic disassociation from the soil?
- Marcos: calibration results for drought deciduous pfts?
- Rosie seeing that they are dying, but not sure about the mortality type
- Charlie:
- Marcos: change deciduosness and see how this fairs
- Aside: Marcos also seeing a lot of termination mortality. Likely unrelated.
- TL;DR: Difference in timescales for hydro mort and enviro mort could result in deciduous pfts dying in conditions that they should be protected against
- deferred due to time
- deferred until next week (missing to many folks)
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
-
FATES modeling meeting: Qing Zhu, Modeling fire risks and impacts at climate scale
- Nothing planned April 10
- Marcos: will reach out to author: https://www.science.org/doi/10.1126/science.adl5414
- Ryan: Buckley?
- Rosie: waiting until Danica is back in May/June
New
-
Crown fire Scottt & Reinhardt
- Adrianna: Xiulin took old PR and bring it up to date with main
- Recommending closing the two older PRs: closed with comment.
- Adrianna: Xiulin took old PR and bring it up to date with main
- Prescribed Fire (#1360): Sam R and Adrianna are reviewing.
- Competitive Exclusion to -1 (#1358): Rosie to review and sign off.
- Default logging parameters (#1359): Main update: Change default logging direct fraction to be one to make sure secondary forest generated is more distinct from primary.
- Spitfire refactor on mortality (#1357): This should come in after prescribed fire #1360.
Next
- GetNutrienTargetCNP for Deciduous (#1348): Ryan testing now.
Updated
- Johnson & Berry electron transpot (#1350): Greg to reach out to Alistair about reviewing
- Seed bank (#1338): Jessie reviewed. Looks ok. Needs deconflict. Ryan to help.
- NCL max (#1315): Length of smoke test? Greg and Ryan to discuss.
- harvesting unoccupied canopy area bugfix (#1339): Reviewed, ready for testing.
In-Progress
- dynamic L2FR (#1353): Needs elm-specific calls reworked: Greg self-assigned
Latest issues and discussions of note
-
unify complexity mode namelist option (#1361)
- Ryan: Is prescribe physiology exclusive to reduced complexity modes?
- Jessie: theoretically no, they could be used together
- Ryan: Is prescribe physiology exclusive to reduced complexity modes?
- Rosie: no new update since Thursday modeling meeting updates. Kicking off new tests. Working on dry deposition as well.
- Adrianna: getting ready to kick off another "one-at-a-time" calibration run using new
fnps
parameter - Jessie: Kasey (ORNL) different allometries for pfts depending on regional (i.e. continent)
- Implementation idea: bounds on where seeds for specific pfts can not recruit. Potential ForestGEO collab.
- Adrianna: this seems like it would benefit GPP calibration as well (seeing region balance shift of GPP for tropical evergreen trees, Asian vs Amazon)
- Rosie: related paper: https://agupubs.onlinelibrary.wiley.com/doi/full/10.1029/2024EF005225
- Rosie: fates-specific surface dataset (to facilitate the above region specific pft discussion)
- Charlie: move LAI data out of surface dataset and let fates use directly (similar to land use data)
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
- XML Parameters (10 minutes)
- FATES modeling meeting: 13 March, project report back
Integrated
- leaf biophysics refactor (#1262), spitfire fire behavior refactor (#1326), fix FATES branch runs (CTSM#2955)
Updated
- ncl max increase (#1315): run long term test status
- luh reorder update (E3SM#7032): tested, waiting integration
- E3SM API37.1 (E3SM#7027): need issue #1354 resolved
New
- Johnson & Berry electron transpot (#1350)
-
dynamic L2FR (#1353): Jessie as reviewer?
- Needs elm-specific calls reworked
Latest issues and discussions of note
- ELM-FATES CNP mass balance error (#1354)
- Carbon balance error API 38 (#1352)
- Land use x PFT hist var issue (#1351)
- Pros:
- CIME makes use of python XML base functionality
- FOX as existing HLM fortran
- fortran code on fates-side that reads in parameters is complicated (since we avoid HLM IO), would simplify any necessary maintenance
- allows us to expand the features that we could control in the parameter file (e.g. metadata) Cons:
- netcdf provides dimensionality fail-safes that we currently "get for free"
- we'd have to take on this functionality ourselves
- We'd need to pull FoX into FATES to make available to all HLMs
- Questions
- parameter ensembles?
- xarray allows for modification of netcdf emsembles easily
- Would the developer's experience in add parameters be simpler (i.e. RegisterParam)
- parameter ensembles?
- ED2 (via Mike Dietz) implemented XML fortran
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Report in on LMWG and E3SM all hands
- Discussion on tracking progress in calibrations and benchmarking
- Calibration update (10 min)
- API38 integrated and tagged (still waiting on e3sm side)
- FATES modeling meeting: 13 March, project report back
Integrated
- parameter migration to namelist (CTSM#2904), two-stream patch area conservation (#1310), johnson & berry namelist and parameter file update (#1344)
Updates
- leaf biophysics refactor (#1262): Needs deconflict and testing. Next tag.
New
- harvesting unoccupied canopy area bugfix (#1339): Greg to review
- GetNutrientTargetCNP update (#1348)
Latest issues and discussions of note
- E3SM DEBUG floating invalid (e3sm#7049): Non-FATES problem, holding up fates integration and debug usage, fix in progress
- Add electron transport formulation (#1337)
- Cold-deciduous climate enveloping (#1345)
- E3SM: focusing on V3
- Utilizing E3SM Diags, the model diagnostics package more, in order to report performance progress of FATES. Can ask for tutorial from Jill or Xylar.
- Includes benchmarking as well as diagnostics (includes ILAMB)
- Related: NorESM looking at utilizing cupid.
- Ryan: GPU push
- E3SM is not concerned with FATES converting to C++. There currently exists multiple ways to integrate existing fortran code with C+
- Utilizing E3SM Diags, the model diagnostics package more, in order to report performance progress of FATES. Can ask for tutorial from Jill or Xylar.
- LMWG
- FATES crop model work seen as necessary for full CLM adoption
- Concerns about fates CPU performance cost
- FATES crop model work seen as necessary for full CLM adoption
- Ryan: centralized work tracking and data sharing repository?
- Initially attempted to centralize, but diverged due to different focus.
- Rosie: no-comp GPP with Medlyn in amazon issue discussion
- Marcos: driest parts of the amazon seems to diverge the most
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
-
FATES modeling meeting: 13 March, project report back
- Greg to send out reply-all to previous notice about this weeks usual meeting being canceled
- Marcos: suggested to move Steven's presentation to April 24 to encourage attendance (avoid scheduleing conflicts with Eastern DVGM meeting)
- Greg to send out notice for API 38 update. Bring this up during
Integrated
- 10 pull requests merged in the last two weeks
- Parameter file migration (#1300): integrated and associated escomp#ctsm2904 to be integrated soon
Update
-
luh reorder update (E3SM#7032): under test, should be b4b
- perlmutter python
create_test
- perlmutter python
- API37.1 update (E3SM#7027): ready for testing
- parameter switch migration (E3SM#6918): ready for testing (post e3sm#7027)
- leaf biophysics refactor (#1262): Greg reviewed. To be tested.
New
-
Seedbank by pft output (#1338)A
- Jessie to take a look into this. Recommending that we wait until after #1262.
- Harvesting bugfix (#1339)
Latest issues and discussions of note
-
file write error (#1333)
- Jessie: Possibly climate forcing data issue?
- ncvarsort.py not preserving order (#1335)
- Add electron transport formulation (#1337)
Canceled due to Federal Holiday
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- ML Canopy Planning (15 min)
- Calibration update (10 min)
- Adrianna has been given expanded fates repo priviledges
- New github issue templates
-
FATES modeling meeting: 13 February, TBD
- Consensus: cancel, Greg to send out notice
- Rosie has reached out to Tom Buckley
Integrated
Update
- cohort insertion and sort refactor (#1317): pulled out non-b4b part and created #1327
- ncl max increase (#1315): Ryan to run long term test status
- leaf biophysics refactor (#1262): Greg reviewed. To be tested.
- nocomp patch cleanup (#1226): Greg reviewed. So minor cleanup TBD. To be tested.
New
- sp mode data driver (CTSM#2952): fixes ESCOMP/ctsm#2945 (htop issue)
Latest issues and discussions of note
-
tree damage module test update (#2959)
- Related: Adrianna to reach out to Jessie to ask about the associated/deprecated damage site-level variables
- Ryan: stakeholders?
- Gordon
- Gautam
- Adrianna and Danica: grant funded work, connect Sam L's ctsm branch to FATES. Working on site-level data collection for validation.
- Timeline: through to 2028
- Includes NCAR NEON stuff as well
- goal: FATES changes to be model agnostic
- action: Ryan and Adrianna to meet to discuss
- Adrianna: once SP bug fixed (via escomp/ctsm#2952), will rerun calibration
- three paper ideas based on this work
- Rosie: new post-doc to help with FATES calibration
- Adrianna to share calibration script location
- Rosie: Matvey thinks that Leung dust scheme (new scheme) might have been built on top of Meier2022
- Adrianna: Zender is the old dust scheme
- We should check in with Erik about Leung
- Adrianna: Zender is the old dust scheme
- Wins (1 min)
- Machine status and meeting notices (5 min)
- Upcoming Meetings (5 min)
- Code of Conduct (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
- Land use fixes integrated
-
FATES modeling meeting: 13 February, TBD
- Rosie to reach out to Tom Buckley
- Ryan: project coordination meeting update?
- Jennifer suggested doing this later as a report back from the CESM-LMWG and E3SM all hands
- Charlie will be out next week
Integrated
Update
- Meier2022 fix (CTSM#2934): Waiting on izumi to come back up to check test results, to be tagged ctsm5.3.022
- Grazing (#1140): Fixes restested and passing now. Still needs baseline comparison. Jennifer reviewed and Charlie addressed comments.
-
parameter migration to namelist (CTSM#2904): waiting on ctsm5.3.022
- Includes parameter file updates PRs
- Refactor per-ageclass history (#1252): scortch height question
New
-
Update
fates_turb_z0mr
(#1319): addresses #1316 - restart fixes for two-stream (#1321): addresses ESCOMP/ctsm#2325
- spitfire fire behavior refactor (#1326): should be b4b
Latest issues and discussions of note
-
Add NBP into
bc_out
(#1320)- The carbon from this is only partially handled. We need to update this to pass the the HLM to the flux coupler.
- Came up in the context of Grazing (#1140)
- Not high priority, need to coordinate with fire emissions
- htop issue: https://github.com/ESCOMP/CTSM/issues/2932#issuecomment-2605781603
- Adrianna to get to this. No questions currently.
-
FDI calculation (#1298)
- Marcos: FDI flag for different approaches?
- Adrianna: yes, there is a Canadian FDI calculation, but Thonicke hardcode
- Action: Adrianna to test the update to match Thonicke
- Marcos: FDI flag for different approaches?
- no updates
- Rosie: Land use tool needs to wor for unstructed grids. Rosie has someone to work on this.
- Wins (1 min)
- Machine status and meeting notices (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Calibration update (10 min)
-
FATES modeling meeting: TBD
- FATES tool poll results
- modify_params had highest uptake, batchpatch, consistent with Ryan's expectations
- immediate take away: don't change anything, look
- office hours: Greg to send out notice
- FATES tool poll results
- Mingjie and Jessie wind mortality meeting this Wednesday 11.30 - others welcome
Integrated
-
Crown depth checks (#1314)
- Marcos: should we add more alllometry checks?
- Greg: definitely worthwhile to add more checks for user conveience.
- One option would be to move convienence checks (i.e. not things that could crash the model) upstream to fates tooling that changes the parameter file.
- Greg: definitely worthwhile to add more checks for user conveience.
- Charlie: sapwood allometry?
- Marcos: should we add more alllometry checks?
Update
-
Meier2022 fix (CTSM#2934): derecho testing looks good, waiting on izumi and ctsm5.3.021 tag completion
- land use fixes (#1273), AllVars update (CTSM#2936), and use_fates_luh order (CTSM#2898) to be combined into #2934
- Grazing (#1140): Charlie update with PRT2 build fix. Greg retesting.
- nocomp patch cleanup (#1226): Needs review.
New
- ncl max increase (#1315): Ryan to run 100-year smoke test to make sure things don't break
Latest issues and discussions of note
-
z0mr parameters (#1316)
- Adrianna is calibrating this, but consensus is that we should update them
- Jessica: ran CLM calibration parameter file in ELM. At preliminary review, it looks good.
- Adrianna: rerunning following
htop
issue fix (Adrianna to make formal issue).
- Charlie: land use spin up
- Default decomp value in ELM is very agressive, Charlie adjusted and spin up works much better
- Might be due to of the decomp method "scheme"
- Default value in CLM is more reasonable relative to updated value
- Rosie: Meier2022
- ELM
- Ryan: making the code more "defensive"
- Initializing fates code with "nan"
- Don't allocate if not used
- Adrianna: API that doesn't allow HLM to have access to data structures
- Greg: look for API update issue/discussion
Canceled due to Federal Holiday
- Wins (1 min)
- Machine status and meeting notices (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Synthetic patches functional testing update (10 min) - deferred
- Calibration update (10 min)
- CTSM temp branch merged into
master
- ctsm5.0.18 has history
time
being on the middle of time bounds- Marcos: will this be reflected in e3sm?
- Greg will reach out to e3sm folks
- Marcos: will this be reflected in e3sm?
- Rosie: New FATES post-doc hire. Will be working on dwarf shrub parameterization.
-
FATES modeling meeting: 16 January, Annemarie Eckes-Shephard
- Ryan to conduct informal poll on using patches.
Integrated
Update
-
fates hydro solver param update (#1263): regression testing underway
- Greg to create xml patch file
- veg temp weight fix (#1306): Needs a second reviewer
- leaf biophys refactor (#1262): Greg and Marcos reviewing
-
Grazing: Greg to deconflict, ok to push directly per Charlie
- Jennifer to quick review this as well.
- Discussion about reasonableness of original values. Consider these highly uncertain for now. Bring these in with zero values now.
- nocomp patch cleanup: TL;DR, de-scoped a lot of changes. Mostly cleanup and "hardening" to make sure everything is consistent.
-
use_fates_luh passing order (CTSM#2898): discussion about
use_fates_potentialveg
name change - Large LAI crash fix (#1269): Ryan refactoring updates
- two-stream finidat fix (#1286): WIP, needs cleanup
New
- fix veg temp weighting (#1306): reviewed, Greg to test
- two-stream area adjustment calculation (#1310): WIP
Latest issues and discussions of note
-
insert_cohort
not preserving sorted order inherently - deferred
- deferred
- Rosie: https://github.com/ESCOMP/CTSM/issues/2932
- Boundary conditions are different between clm6 and fates
- Displacement height needs to be fixed, biasing SP results. Is Meier2022 the default? Check in with Adrianna.
- Charlie: ELM using ZengWang? Rosie: yes
- Ryan: create quick PR to make sure ZengWang is default if fates is on? Greg to address.
- Jessie will reach out to Adrianna for latest parameter file and create a new smoke test
- Wins (1 min)
- Machine status and meeting notices (5 min)
- PR board status (10 min)
- Latest issues (5 min)
- Synthetic patches for functional testing
- Calibration update (10 min)
- FATES modeling meeting: 16 January, Annemarie Eckes-Shephard
Integrated
- modify_fates_paramfile fix (#1275), Indexing python tool fix (#1287), cmake functional test fix (#1303), ROS refactor (#1297), frac_burnt zero fix (#1302)
Update
- Land use fixes (#1273): Deconflicted and reviewed. Build test failing.
- e3sm API37 (E3SM#6762): Waiting on integration
- ctsm hydro test update (CTSM#2882): On hold due to izumi nag compiler test fails (CTSM#2924)
Latest issues and discussions of note
-
FDI calculation (#1298)
- Xuilin, NGEE-tropics phase 3 has a bunch of work planned (Lara)
- Adrianna to bring this to the CA meeting
- Jennifer will give Lara a heads up about discussing this at a future meeting
-
fire calculations regardless of event (#1299)
- Adrianna: do we want to avoid calculating values when there is no fire?
- Sam: not doing so will improve computation. Maybe improve history output.
- Sam: some of the fire outputs were weighted by burned area, but not all outputs.
- Rosie: you might want to know the potential effects regardless of fire active or not (are you looking "upstream" or "downstream") .
- Adrianna: do we want to avoid calculating values when there is no fire?
- PVT run FAIL (CTSM#2919)
- Adrianna developing "dummy" patches for use with funtional and unit tests
- Idealized biomes with simplistic, well-defined values
- Motivated by future work to conduct with Danica as well as creating unit tests for cohort sorting, patch insertion, etc.
- no new updates due to break
- Rosie: NorESM working on repo to keep recipes for simulations being run. Maybe preview next week.
2025 Software Engineering Meeting Notes
2024 Software Engineering Meeting Notes
2023 Software Engineering Meeting Notes
2022 Software Engineering Meeting Notes
2021 Software Engineering Meeting Notes
FATES API and Host Land Model compatibility table
Relevant References page (User's Guide)
Moorcroft et al. 2001. Ecological Monographs, 74:557-586.