Skip to content

fix 32-bit usage of size_t and support non-intel arches #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix 32-bit usage of size_t and support non-intel arches #207

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84fc680
fix 32-bit usage of size_t
drew-parsons Jan 5, 2025
bc489e2
support non-x86 arches missing RDTSC
drew-parsons Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libsrc/core/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
#ifdef NETGEN_ARCH_AMD64
#ifdef WIN32
#include <intrin.h> // for __rdtsc() CPU time step counter
#else
#define NGCORE_HAVE_RDTSC
#elif defined __SSE__
#define NGCORE_HAVE_RDTSC
#include <x86intrin.h> // for __rdtsc() CPU time step counter
#endif // WIN32
Comment on lines +22 to 26
Copy link
Contributor

@StefanBruens StefanBruens Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same define in both branches ...

#endif // NETGEN_ARCH_AMD64
Expand Down Expand Up @@ -65,7 +67,7 @@ namespace ngcore
{
#if defined(__APPLE__) && defined(NETGEN_ARCH_ARM64)
return mach_absolute_time();
#elif defined(NETGEN_ARCH_AMD64)
#elif defined(NETGEN_ARCH_AMD64) || defined(NGCORE_HAVE_RDTSC)
Copy link
Contributor

@StefanBruens StefanBruens Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change has no effect, NGCORE_HAVE_RDTSC is only ever defined if NETGEN_ARCH_AMD64 is defined.

return __rdtsc();
#elif defined(NETGEN_ARCH_ARM64) && defined(__GNUC__)
// __GNUC__ is also defined by CLANG. Use inline asm to read Generic Timer
Expand All @@ -74,6 +76,8 @@ namespace ngcore
return tics;
#elif defined(__EMSCRIPTEN__)
return std::chrono::high_resolution_clock::now().time_since_epoch().count();
#elifndef NGCORE_HAVE_RDTSC
Copy link
Contributor

@StefanBruens StefanBruens Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always true ...

return TTimePoint(std::chrono::steady_clock::now().time_since_epoch().count());
#else
#warning "Unsupported CPU architecture"
return 0;
Expand Down