PDF generation is broken

[bouweandela]

https://github.com/NLeSC/guide/runs/6401893102?check_suite_focus=true

@sverhoeven Would you have time to take a look at this?

[vedran-kasalica]

I looked into the issue and the PDF can be generated locally without issues not as a GitHUb action with docsify-pdf-converter (we looked into alternatives and docker-docsify-pdf looked promising). It is difficult to test whether it can be pushed to Zenodo at the moment (the last step in the workflow). We can wait for the new release and fix it if it fails to publish the PDF to Zenodo.

[egpbos]

The PDF generation itself has been fixed in #393. The only thing remaining for this issue is to check whether the upload to Zenodo is working when we publish the v1.0 release.

[c-martinez]

Hey @vedran-kasalica, @egpbos just did a release, but it looks like the PDF build is failing. Any idea what may be going wrong?

[vedran-kasalica]

@c-martinez I am not sure, but I can look into it this week

[c-martinez]

Awesome, thanks @vedran-kasalica !

[egpbos]

Any luck with this so far? :)

[vedran-kasalica]

I'm sorry, it slipped my mind completely. I can have a look later next week, but if you have time before feel free to

[vedran-kasalica]

Sorry for the delay, I think that #437 solves the issue. Unfortunately, I cannot test if the PDF will be automatically published to Zenodo on Release. I cannot see the Zenodo configuration, as I am not an owner.

[egpbos]

Reopening until we confirmed that the fix works (can only be tested on main).

[egpbos]

I manually started the workflow on main. This will upload an unreleased version.

[egpbos]

...or at least it should, but the upload to Zenodo step is skipped 😢

[egpbos]

Ah, that step also only triggers on release. I guess we'll do a release then :) This is warranted anyway, because we have the new Rust chapter. I will fix a few broken links before releasing...

[egpbos]

ARrrgh, released 1.1, but it still doesn't upload: https://github.com/NLeSC/guide/actions/runs/14731240906/job/41345795858

Also, the new Zenodo entry is still used (ref #427): https://zenodo.org/records/15303399

[egpbos]

It seems likely that the action we are using for uploading to Zenodo is just broken, since it has not been updated in 4 years: https://github.com/iomega/zenodo-upload

Perhaps we should instead switch to https://github.com/zenodraft/action. We can use that with the filenames config option to only upload the PDF. What's also very nice about this action is that it can use Zenodo Sandbox for testing, so that we don't have to do this annoying testing in main thing anymore.

If someone has time to try switching to this, a PR would be most welcome!

[c-martinez]

I've created a draft PR #440, but I think it might need a bit of testing before merging.