Fix the error that prevented generating the PDF guide on release #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nlesc-guide-testing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
egpbos
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Updated the Generate PDF GitHub action to use the
--no-sandboxfor chromium, as explained in kernoeb/docker-docsify-pdf#13.This should fix #270 (comment).
Note: We are using the
maintag and not latest, because they did not make a release since they introduced--no-sandbox.I tested the updated GitHub Action here.
Checklist
SIGNIFICANT changes / additions, e.g. new chapters