-
Notifications
You must be signed in to change notification settings - Fork 204
GCAFS prep emissions update - fire emissions #3713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
GCAFS prep emissions update - fire emissions #3713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates aerosol configuration and emissions handling for the UFS-Aerosols system by consolidating file management and enhancing modularity. Key changes include:
- Removing legacy logic for generating the AERO_ExtData.rc file and consolidating emission configuration files.
- Adding a link to chemical input files in forecast_predet.sh and updating configuration templates in both aerosol and chemical configuration files.
- Refactoring configuration files to improve clarity and maintainability.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ush/parsing_namelists_GOCART.sh | Removed legacy dynamic generation of AERO_ExtData.rc. |
| ush/forecast_predet.sh | Added linking for CHEM_INPUT to ensure chemical input file availability. |
| parm/ufs/gocart/ExtData.* | Removed obsolete emission configuration files, consolidating them into AERO_ExtData.rc. |
| parm/ufs/gocart/AERO_ExtData.rc | Updated emission entries to use chemical input paths and adjusted emission factors. |
| parm/chem/chem_emission.yaml.j2 | Updated templating loops for QFED variables and file copying operations. |
| dev/parm/config/gfs/config.com | Added new chemical template paths. |
| dev/parm/config/gcafs/config.aero.j2 | Reorganized aerosol sections and introduced new aerosol emission settings. |
2e06fb3 to
b534a8b
Compare
|
@bbakernoaa I have updated the description of this PR to close #4248 once testing is complete. |
Thanks now I need to update this workflow branch to point to this new fix directory right? |
|
@bbakernoaa Yes, that's correct. |
|
@DavidHuber-NOAA this should be ready for the ci tests now. |
|
Launching on C6 and WCOSS2. |
|
It looks like C6 is not triggering automatically, so I will run it manually. @DavidHuber-NOAA It looks like you entered the PR number incorrectly: But will still fail on build on C6 until we update GitHub CLI for checkout PRs |
|
@bbakernoaa Can you resolve the conflict in gcafs_tasks.py? The tests have finished building but have not started running on C6 and Cactus, so I can still incorporate this update. |
|
The tests are now running on Cactus and C6. |
|
@bbakernoaa Tests are failing on WCOSS2 and C6 with the following or similar errors: It looks like there is a key missing from a dictionary. Can you check this out and test it locally, please? |
|
@DavidHuber-NOAA yes I'll test it out asap |
|
@DavidHuber-NOAA There was two small errors that have been corrected. I did a run on gaeac6 using the ci ./generate_workflows.sh -A bil-fire3 -C -c /gpfs/f6/bil-fire3/world-shared/Barry.Baker/EXPTS/ All jobs passed except the arch since i don't have permission to the default archive directory. |
Description
Resolves #3712
Resolves #3827
Resolves #4248
This pull request introduces significant updates to the aerosol configuration and emission handling in the UFS-Aerosols system, streamlining file management, improving modularity, and consolidating configuration files. Key changes include restructuring aerosol configuration files, enhancing biomass burning emissions handling, and updating the chemical input file linking process.
Aerosol Configuration Updates:
config.aero.j2to organize settings into distinct sections for aerosol and emission configurations, including the addition of new variables likeAERO_EMIS_FIRE_VERSIONandAERO_EMIS_FIRE_HIST. [1] [2]Emission Data Management:
ExtData.gbbepx,ExtData.qfed, andExtData.none) into a single file,AERO_ExtData.rc, for better modularity and maintainability. Removed redundant and unused emission entries. [1] [2] [3] [4]Chemical Input File Handling:
CHEM_INPUT) inforecast_predet.shto ensure proper file availability during runtime.Removal of Legacy Code:
AERO_ExtData.rcinparsing_namelists_GOCART.sh, as the new consolidated configuration file eliminates the need for dynamic generation.Additional Updates:
config.comto include new template paths for chemical restart and input files, improving file organization.Type of change
Change characteristics
How has this been tested?
Checklist