Skip to content

Conversation

@DWesl
Copy link
Contributor

@DWesl DWesl commented Nov 25, 2025

Description

SFS runs currently archive ocean and ice data unconditionally. This PR conditions that archiving on the variables DO_OCN and DO_ICE, borrowed from another file (this is the example I can find)

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

I have checked that this change allows the archive task to succeed for ATM-only SFS runs. I have not yet checked that this still includes the ocean and ice files in archives with S2S SFS runs.

Tests so far are forecast-only on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

I have checked that this change allows the archive task to succeed for ATM-only SFS runs.  I have not yet checked that this still includes the ocean and ice files in archives with S2S SFS runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant