Skip to content

Conversation

HansVahlenkamp
Copy link
Contributor

Synchronize output file before closing and check for errors. Also increase version number.

Synchronize output file before closing and check for errors.  Also increase version number.
@HansVahlenkamp HansVahlenkamp linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HansVahlenkamp
Copy link
Contributor Author

I also ran the "make check" step when building FRE-NCtools with this updated mppnccombine.c and there were no failures.

@ceblanton ceblanton merged commit 077d618 into main Sep 26, 2024
8 checks passed
@underwoo underwoo deleted the 313-mppnccombine-should-sync-before-closing-output-file branch October 10, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mppnccombine should sync before closing output file
3 participants