forked from mom-ocean/MOM6
-
Notifications
You must be signed in to change notification settings - Fork 73
Commit e486f50
(*) Multiple fixes for the ray tracing (#947)
* (*) Multiple fixes for the ray tracing
- Solve the issue of rays not propagating through the northfold: the
use of pass_vector for speed_[x/y] is not appropriate since these arrays
are meant to be scalar and the direction is contained in the angle dimension
of energy. changing to regular pass_var at the appropriate cell location fixes it
- The energy gets trapped at critical latitude: this PR introduces 2 options for
energy propagation, either propagate along the critical latitude or reflect on it.
These are controlled by TURN_CRITICAL_LAT (False: get trapped, True: do something)
and REFLECT_CRITICAL_LAT (True: reflect like a solid wall, False: propagate along)
- Several divisions by constant number were eliminated
* (*) Multiple fixes for the ray tracing
- Solve the issue of rays not propagating through the northfold: the
use of pass_vector for speed_[x/y] is not appropriate since these arrays
are meant to be scalar and the direction is contained in the angle dimension
of energy. changing to regular pass_var at the appropriate cell location fixes it
- The energy gets trapped at critical latitude: this PR introduces 2 options for
energy propagation, either propagate along the critical latitude or reflect on it.
These are controlled by TURN_CRITICAL_LAT (False: get trapped, True: do something)
and REFLECT_CRITICAL_LAT (True: reflect like a solid wall, False: propagate along)
- Several divisions by constant number were eliminated
* add call to turning latitude in propagate_x
This should satisfy the rotational symmetry.
As expected, this has no impact on global case
since reflected energy from propagate_x then
does not need to be reflected in propagate_y.
* update units order
---------
Co-authored-by: Raphael Dussin <Raphael.Dussin@noaa.gov>1 parent c23c244 commit e486f50Copy full SHA for e486f50
File tree
Expand file treeCollapse file tree
1 file changed
+265
-18
lines changedFilter options
- src/parameterizations/lateral
Expand file treeCollapse file tree
1 file changed
+265
-18
lines changed
0 commit comments