Fix ALE_sponge tendency diagnostic units #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
force-pushed
the
fix_ALE_sponge_diagnostic
branch
from
b9e296e to
2ffd656
Compare
marshallward
reviewed
Jan 2, 2025
Hallberg-NOAA
force-pushed
the
fix_ALE_sponge_diagnostic
branch
from
2ffd656 to
838d52f
Compare
Corrected the units and conversion factor in init_ALE_sponge_diags for the various sp_tendency_... diagnostics. Previously they had only been correct for the tendencies of nondimensional quantities. The code also now stores the scaling factor that is set in set_up_ALE_sponge_field_fixed for later use in registering the sponge tendency diagnostics. Several instances of unusual spacing around semicolons in MOM_ALE_sponge were also standardized. The documented units and conversion factors for some diagnostics were corrected, but all solutions are bitwise identical.
Hallberg-NOAA
force-pushed
the
fix_ALE_sponge_diagnostic
branch
from
838d52f to
279e7ff
Compare
marshallward
approved these changes
Jan 7, 2025
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/25966. |
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the units and conversion factor in
init_ALE_sponge_diags()for the varioussp_tendency_...diagnostics. Previously they had only been correct for the tendencies of nondimensional quantities. The code also now stores the scaling factor that is set inset_up_ALE_sponge_field_fixed()for later use in registering the sponge tendency diagnostics. Several instances of unusual spacing around semicolons inMOM_ALE_sponge.F90were also standardized. The documented units and conversion factors for some diagnostics were corrected, but all solutions are bitwise identical.