Depreciate TIDE_SAL_SCALAR_VALUE
#819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrwang0
changed the title
TIDE_SAL_SCALAR_VALUE with old_nameTIDE_SAL_SCALAR_VALUE
Hallberg-NOAA
requested changes
Jan 31, 2025
herrwang0
force-pushed
the
add_sal_old_name
branch
from
ab1f579 to
9e226f1
Compare
Hallberg-NOAA
approved these changes
Jan 31, 2025
Using the recently added `old_name` option in `get_params`.
Hallberg-NOAA
force-pushed
the
add_sal_old_name
branch
from
9e226f1 to
627d55c
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26236 with the expected changes in some messages describing some parameters in the MOM_parameter_doc files. |
kshedstrom
pushed a commit
to ESMG/MOM6
that referenced
this pull request
Mar 17, 2025
Using the recently added `old_name` option in `get_params`.
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the recently introduced
old_nameoption inget_paramto replace runtime parameterTIDE_SAL_SCALAR_VALUEwithSAL_SCALAR_VALUEin a more elegant way.No answer changes.