+Find fluxes%netFWGlobalAdj in rescaled units #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
the
refactor
Hallberg-NOAA
changed the title
herrwang0
approved these changes
Feb 15, 2025
Revised the calculation of the netFWGlobalAdj, vPrecGlobalAdj and saltFluxGlobalAdj elements of the forcing type to work in dimensionally rescaled units, making use of the unscale argument to reproducing_sum. This change includes the addition of conversion factors to the register_scalar_field calls, and changes to the units of 15 variables to be rescaled. A total of 27 instances of multiplication by unit conversion factors were eliminated as a part of these changes, with 15 other unit conversion factors added via unscale arguments. All answers and output are bitwise identical, but there are changes to the units of three variables in a transparent type.
Hallberg-NOAA
force-pushed
the
rescale_GlobalAdj
branch
from
3ef92e5 to
7c62a15
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26403. |
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the calculation of the
netFWGlobalAdj,vPrecGlobalAdjandsaltFluxGlobalAdjelements of theforcingtype to work in dimensionally rescaled units, making use of theunscaleargument toreproducing_sum(). This change includes the addition of conversion factors to threeregister_scalar_fieldcalls, and changes to the units of 15 variables to be rescaled. A total of 27 instances of multiplication by unit conversion factors were eliminated as a part of these changes, with 15 other unit conversion factors added viaunscalearguments. All answers and output are bitwise identical, but there are changes to the units of three variables in a transparent type.