(*)Consolidate conversion of 4 salt tendency diags #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collected the conversion factors for the 4 salt tendency diagnostics diabatic_salt_tendency, diabatic_salt_tendency_2d, boundary_forcing_salt_tendency and boundary_forcing_heat_tendency_2d out of the calculation of the diagnostics before they are posted and into the conversion argument in their register_diag_field calls. This change simplifies the code where the diagnostics are calculated, but although all expressions are mathematically equivalent, there is a change in the order of arithmetic with which these 4 diagnostics are calculated, so answers will change at roundoff, although this is unlikely to be detected if the diagnostics are being written as 32 bit floats. All model solutions are bitwise identical.
Hallberg-NOAA
added
refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #840 +/- ##
============================================
- Coverage 38.11% 38.10% -0.01%
============================================
Files 298 298
Lines 87642 87640 -2
Branches 16416 16416
============================================
- Hits 33401 33399 -2
Misses 48219 48219
Partials 6022 6022 ☔ View full report in Codecov by Sentry. |
|
Moving the S to ppt scaling from calculation to diagnostic streamlines the calculation but also causes a change in the bit repro. Since they are unlikely to show up on a bin32 float, this is probably OK to merge. But we will have to report this in the future PR to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collected the conversion factors for the 4 salt tendency diagnostics
diabatic_salt_tendency,diabatic_salt_tendency_2d,boundary_forcing_salt_tendencyandboundary_forcing_heat_tendency_2dout of the calculation of the diagnostics before they are posted and into the conversion argument in theirregister_diag_field()calls. This change simplifies the code where the diagnostics are calculated, but although all expressions are mathematically equivalent, there is a change in the order of arithmetic with which these 4 diagnostics are calculated, so answers will change at roundoff, although this is unlikely to be detected if the diagnostics are being written as 32 bit floats. All model solutions are bitwise identical.