Update to AX_FC_REAL8 macro #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactor of AX_FC_REAL8. The GNU test for -f-default-real-8 and -fdefault-double-8 is split into two separate tests. The macro was also redesigned to avoid duplication of the test program, and to follow the same pattern as in autoconf's lib/fortran.m4. The AMD flang compilers require -fdefault-real-8 but not -fdefault-double-8. We now test for the first flag before testing for both. This patch will slightly improve support for AMD flang compilers.
marshallward
force-pushed
the
ac_real8_update
branch
from
195f769 to
870a2d2
Compare
adcroft
approved these changes
Apr 15, 2025
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/27136. |
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of
AX_FC_REAL8. The GNU test for-fdefault-real-8and-fdefault-double-8is split into two separate tests. The macro was also redesigned to avoid duplication of the test program, and to follow the same pattern as in autoconf'slib/fortran.m4.The AMD flang compilers require
-fdefault-real-8but not-fdefault-double-8. We now only test for the first flag both before testing for both.This patch will slightly improve support for AMD flang compilers.