Allow some tracers to use a different advection scheme #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cleanup of tracer advection in preparation for adding higher order advection options in a subsequent pull request. All existing cases are bit for bit the same as before. Many of the tracer modules have code lines (exclusive of comments) of more than 100 characters. These have been edited for length in the modules updated here. Internally, TRACER_ADVECTION_SCHEME is now implmented as an integer lookup table, rather than as a set of logicals. Regional and OBC dye tracers can now be used in the same model run, provided the optional NUM_DYED_TRACERS is used in place of NUM_DYE_TRACERS for dyed_obc tracers with NUM_DYE_TRACERS then referring to the number of regional dye tracers. They can both now also go through their initialization code if they are not found in the restart files. For OBC dye tracers this requires TRACERS_MAY_REINIT=.true.. The new option to specify a different advection scheme for some passive tracers has been implemented for regional and OBC dye tracers. This is controlled by DYED_TRACER_ADVECTION_SCHEME for OBC dye tracers, and by DYExxx_TRACER_ADVECTION_SCHEME, where xxx is the 3 digit tracer number, for regional dye tracers. It is possible to test multiple advection schemes in the same model run by configuring multiple regional tracers with the same region but different advection schemes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup of tracer advection in preparation for adding higher order advection options in a subsequent pull request. All existing cases are bit for bit the same as before.
Many of the tracer modules have code lines (exclusive of comments) of more than 100 characters. These have been edited for length in the modules updated here.
Internally, TRACER_ADVECTION_SCHEME is now implmented as an integer lookup table, rather than as a set of logicals.
Regional and OBC dye tracers can now be used in the same model run, provided the optional NUM_DYED_TRACERS is used in place of NUM_DYE_TRACERS for dyed_obc tracers with NUM_DYE_TRACERS then referring to the number of regional dye tracers. They can both now also go through their initialization code if they are not found in the restart files. For OBC dye tracers this requires TRACERS_MAY_REINIT=.true..
The new option to specify a different advection scheme for some passive tracers has been implemented for regional and OBC dye tracers. This is controlled by DYED_TRACER_ADVECTION_SCHEME for OBC dye tracers, and by DYExxx_TRACER_ADVECTION_SCHEME, where xxx is the 3 digit tracer number, for regional dye tracers. It is possible to test multiple advection schemes in the same model run by configuring multiple regional tracers with the same region but different advection schemes.