.testing: Fix optimized target paths #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the path for the optimized target builds (opt_target) used in the profiling tests. Previously they were pointing to the wrong directories and were never built. Due to oddities of rule order and overrides, the optimized targets were using the latest code. That is, **the perf tests were being run against themselves**. The perf and profile rules now correctly compare optimized output to the optimized target output (typically dev/gfdl).
perf diff output used a relatively small value for comparison (32 chars) which unfortunately does not work for many functions in Fortran modules. This number has been increased to 60, and is now set as a variable within the code.
adcroft
approved these changes
Mar 31, 2025
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the path for the optimized target builds (opt_target) used in
the profiling tests. Previously they were pointing to the wrong
directories and were never built.
Due to oddities of rule order and overrides, the optimized targets were
using the latest code. That is, the perf tests were being run against
themselves.
The perf and profile rules now correctly compare optimized output to the
optimized target output (typically dev/gfdl).
This PR also contains a minor improvement to the perf comparison script output.