Skip to content

Conversation

kshedstrom
Copy link

This is a draft PR for thickness reservoirs. The code creates an object, it doesn't break existing cases, and restarts seem to work. Some questions remain:

  • Is this the correct timestepping of them?
  • They are turned on by setting either OBC_TRACER_RESERVOIR_LENGTH_SCALE_OUT or
    OBC_TRACER_RESERVOIR_LENGTH_SCALE_IN. Is this what we want?
  • This doesn't (yet) handle the SIMPLE_H obc case which could help the layered Kelvin wave case.
  • I check for the external variable "DZ" for reading dz. Not sure what we want here either, not that this is completely wired up yet.
  • Happy to chat about this if it helps.

@kshedstrom
Copy link
Author

Thank you for the thoughtful suggestions. Hopefully they have all been addressed now.

@theresa-cordero theresa-cordero self-requested a review September 3, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants