Frequency-dependent drag in tensor form#978
Merged
Merged
Conversation
c2xu
force-pushed
the
c2xu/wave_drag_2
branch
from
7c00910 to
caeebbc
Compare
Hallberg-NOAA
requested changes
Nov 21, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have a few minor and specific changes that I think would make this commit slightly better, which I have described in separate specific comments, but once they are in place I think that this PR will be ready to go.
c2xu
force-pushed
the
c2xu/wave_drag_2
branch
from
caeebbc to
e36c4a0
Compare
Author
|
Thanks, @Hallberg-NOAA, these changes have been implemented. |
Hallberg-NOAA
approved these changes
Nov 24, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes now look good to me. Thank you for this valuable contribution.
This commit allows the frequency-dependent drag to be implemented in tensor form, by incorporating the off-diagonal components of the wave drag tensor into the MOM_wave_drag module.
Hallberg-NOAA
force-pushed
the
c2xu/wave_drag_2
branch
from
e36c4a0 to
908ad4d
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/29350. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows the frequency-dependent drag to be implemented in tensor form, by incorporating the off-diagonal components of the wave drag tensor into the MOM_wave_drag module.
This is part of the Pull Request I opened earlier (#961), but is relevant to the frequency-dependent drag only.