[Tool] Best Guess Netcdfs diff #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oelbert
requested changes
Jul 9, 2025
| def get_parser(): | ||
| parser = argparse.ArgumentParser( | ||
| "Attempt to diff two NetCDFs with similar data." | ||
| "Differences that can be reconcialed are strict domain vs halo, variable name mapping." |
There was a problem hiding this comment.
Suggested change
| "Differences that can be reconcialed are strict domain vs halo, variable name mapping." | |
| "Differences that can be reconciled are strict domain vs halo, variable name mapping." |
| parser = argparse.ArgumentParser( | ||
| "Attempt to diff two NetCDFs with similar data." | ||
| "Differences that can be reconcialed are strict domain vs halo, variable name mapping." | ||
| "They program will report on assumptions taken." |
There was a problem hiding this comment.
Suggested change
| "They program will report on assumptions taken." | |
| "The program will report on assumptions taken." |
| parser.add_argument( | ||
| "netcdf_A", | ||
| type=str, | ||
| help="path of NetCDFs, named A in the logs.", |
There was a problem hiding this comment.
Suggested change
| help="path of NetCDFs, named A in the logs.", | |
| help="path of first NetCDF file, named A in the logs.", |
| parser.add_argument( | ||
| "netcdf_B", | ||
| type=str, | ||
| help="path of NetCDFs, named B in the logs.", |
There was a problem hiding this comment.
Suggested change
| help="path of NetCDFs, named B in the logs.", | |
| help="path of second NetCDF file, named B in the logs.", |
| xr.Dataset(dataset).to_netcdf(f"best_guest_diff_{pathlib.Path(netcdf_A).stem}.nc4") | ||
|
|
||
|
|
||
| def entry_point(): |
There was a problem hiding this comment.
too good to call it main()? 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change
This PR proposes a new tool to check NetCDFs against one another with a series of guess to match compute domains. The tool describe it's logic as it goes down and fail if it can't resolve.
Options for name mapping & halo size.
After (re)installing NDSL, it can be called with
where
name_mappingis a yaml file with a single dictionary mapping name in A to B.Minor QOL
quantity.to_netcdfwhen no rank is given looks at the rank itselfndsl_logis imported early to avoid circular dependencies