Skip to content

Conversation

laurenchilutti
Copy link
Contributor

@laurenchilutti laurenchilutti commented Aug 20, 2025

Describe your changes

  1. Remove the video clip from the README. This was out of date. Can make a new one if it is useful in the future.

Issue ticket number and link (if applicable)

Fixes #455
Fixes #547

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.11%. Comparing base (9bce71f) to head (ec7bd82).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   73.11%   73.11%           
=======================================
  Files          63       63           
  Lines        4077     4077           
=======================================
  Hits         2981     2981           
  Misses       1096     1096           
Flag Coverage Δ
unittests 73.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ence to canopy. Also use fre make and not fremake
@laurenchilutti laurenchilutti marked this pull request as ready for review August 20, 2025 12:34
Copy link
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

req changes

# Create and run the compile script
fre make compile-script -y [model yaml file] -p [platform] -t [target] --execute

# Run all of fremake
# Run fre make checkout-script, fre make makefile, and fre make compile-script in order
Copy link
Collaborator

@singhd789 singhd789 Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to put this in it's own code blurb? Like have a snippet of explanation like "Or run the fre make steps in an all-encompassing tool ..." right before, then add the fre make all command.

I don't want it to seem like the user has to run all the steps AND the all step

# Create and run checkout script
fre make checkout-script -y [model yaml file] -p [CONTAINER PLATFORM] -t [target] --execute

# Create Makefile
fre make makefile -y [model yaml file] -p [CONTAINER PLATFORM] -t [target]

#Create a Dockerfile
fre make dockerfile -y [model yaml file] -p [CONTAINER PLATFORM] -t [target]

# Create and run the Dockerfile
fre make dockerfile -y [model yaml file] -p [CONTAINER PLATFORM] -t [target] --execute
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following my other comment - the same things but with container platform:
fre make all -y [model yaml file] -p [CONTAINER PLATFORM] -t [target] --execute will create a container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: fre make readme update docs: README: Updates Needed
3 participants