-
Notifications
You must be signed in to change notification settings - Fork 20
Docs: pp docs/ #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Docs: pp docs/ #608
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 73.11% 73.11%
=======================================
Files 63 63
Lines 4077 4077
=======================================
Hits 2981 2981
Misses 1096 1096
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reqs changes
Are you including the modifications to the description of what -e -p -t mean in the fre-cli context as part of this PR? If not, the changes to split-netcdf and split-netcdf wrapper in pp.rst look good! |
The changes look good! The syntax is fixed, I think that the description is
clear, and the examples make sense in this context.
…On Tue, Aug 26, 2025 at 3:02 PM Lauren Chilutti ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/tools/pp.rst
<#608 (comment)>:
> * Module(s) needed: n/a
* Example: ``fre pp split-netcdf -f 19790101.atmos_tracer.tile6.nc -o output/ -v tasmax,tasmin``
``split-netcdf-wrapper``
------------------------
* Given a directory structure with netcdf files, calls split-netcdf on individual netcdf files
-* Minimal Syntax: ``fre pp split-netcdf-wrapper -i input/ -o output/ [-c yaml_component -s history_source -y yamlfile.yml | --split-all-vars] [--use-subdirs]``
+* Minimal Syntax: ``fre pp split-netcdf-wrapper -i input/ -o output/ -s history_source [-c yaml_component -y yamlfile.yml --split-all-vars --use-subdirs]``
I updated these examples - let me know what you think!
—
Reply to this email directly, view it on GitHub
<#608 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC362WUS4SFSKEU33AYIWAD3PSVJ7AVCNFSM6AAAAACELNNAK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNJWHE2DCMZUGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Carolyn Whitlock
|
No I am not - I made more issues to fix those as they would be changes in files other than pp.rst and postprocess.rst! #620 and #621 |
Describe your changes
So far this PR fixes some yaml convention changes and sub tool naming conventions in pp docs
I have updated yaml schema changes and frepp cli intefaces where necessary.
Issue ticket number and link (if applicable)
Fixes #475
Checklist before requesting a review