Skip to content

Conversation

laurenchilutti
Copy link
Contributor

@laurenchilutti laurenchilutti commented Aug 20, 2025

Describe your changes

So far this PR fixes some yaml convention changes and sub tool naming conventions in pp docs
I have updated yaml schema changes and frepp cli intefaces where necessary.

Issue ticket number and link (if applicable)

Fixes #475

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.11%. Comparing base (9bce71f) to head (96cc272).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   73.11%   73.11%           
=======================================
  Files          63       63           
  Lines        4077     4077           
=======================================
  Hits         2981     2981           
  Misses       1096     1096           
Flag Coverage Δ
unittests 73.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laurenchilutti laurenchilutti marked this pull request as ready for review August 20, 2025 13:52
Copy link
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reqs changes

@cwhitlock-NOAA
Copy link
Collaborator

Are you including the modifications to the description of what -e -p -t mean in the fre-cli context as part of this PR?

If not, the changes to split-netcdf and split-netcdf wrapper in pp.rst look good!

@cwhitlock-NOAA
Copy link
Collaborator

cwhitlock-NOAA commented Aug 26, 2025 via email

@laurenchilutti
Copy link
Contributor Author

Are you including the modifications to the description of what -e -p -t mean in the fre-cli context as part of this PR?

If not, the changes to split-netcdf and split-netcdf wrapper in pp.rst look good!

No I am not - I made more issues to fix those as they would be changes in files other than pp.rst and postprocess.rst! #620 and #621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: update fre pp usage in docs/
5 participants