-
Notifications
You must be signed in to change notification settings - Fork 20
Fixes bugs in regrid-xy, restore original directory structure #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
+ Coverage 73.67% 73.74% +0.06%
==========================================
Files 65 65
Lines 4175 4178 +3
==========================================
+ Hits 3076 3081 +5
+ Misses 1099 1097 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
largely looks good, but i'm concerned the os.chdir
isn't as transient as we need it to be.
Remember to finish reviewing this PR 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know @mlee03 appreciates a thorough review, so i took more time to be more thorough!
additional change that will come, the f-strings will be changed to use %s for the logger |
8e80d94
to
750281c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments look like they're addressed and the tests pass! Wooo, good job. I'd just say merge in main and we're good to go.
Describe your changes
This PR restores the original directory structure where
work_dir
is the working directory containing the extracted grid_spec.nc, mosaic, and grid files from the grid_spec tarfile.remap_dir
is the directory containing the remap files that are either generated or reused during the regridding workflow.These directories remove the need to move and copy relevant files before
fregrid
is invoked.This PR still requires changes to fre-workflow and requires testing within the workflow
Issue ticket number and link (if applicable)
#609
Checklist before requesting a review