-
Notifications
You must be signed in to change notification settings - Fork 20
Add CODE_STYLE.md #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add CODE_STYLE.md #623
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
+ Coverage 73.11% 73.28% +0.16%
==========================================
Files 63 63
Lines 4077 4069 -8
==========================================
+ Hits 2981 2982 +1
+ Misses 1096 1087 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm going to be hard to satisfy on this front. Not impossible, it's just that once we implement a CODE_STYLE.md
, it's hard to go back.
@ilaflott I'll be updating the style guide to address your comments, just not immediately as I have other priority tasks. Just want you to know I saw this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I really like it.
.. warning:: This is a warning | ||
""" | ||
|
||
#this is an example of type hinting a variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type hinting for variables outside of method declarations- too much?
Describe your changes
Documentation has been a docus during the latest
fre-cli
development cycle. This PR adds a style guide defining specific rules to follow when documenting.Future improvements to this style guide can include a reference to specific PEP standards to follow in this repository.
Issue ticket number and link (if applicable)
I didn't start with an issue - I can if needed!
Checklist before requesting a review