Skip to content

Conversation

laurenchilutti
Copy link
Contributor

Describe your changes

Documentation has been a docus during the latest fre-cli development cycle. This PR adds a style guide defining specific rules to follow when documenting.

Future improvements to this style guide can include a reference to specific PEP standards to follow in this repository.

Issue ticket number and link (if applicable)

I didn't start with an issue - I can if needed!

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

@laurenchilutti laurenchilutti self-assigned this Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.28%. Comparing base (9bce71f) to head (2f6004e).
⚠️ Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   73.11%   73.28%   +0.16%     
==========================================
  Files          63       63              
  Lines        4077     4069       -8     
==========================================
+ Hits         2981     2982       +1     
+ Misses       1096     1087       -9     
Flag Coverage Δ
unittests 73.28% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm going to be hard to satisfy on this front. Not impossible, it's just that once we implement a CODE_STYLE.md, it's hard to go back.

@laurenchilutti
Copy link
Contributor Author

@ilaflott I'll be updating the style guide to address your comments, just not immediately as I have other priority tasks. Just want you to know I saw this!

Copy link
Collaborator

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I really like it.

.. warning:: This is a warning
"""

#this is an example of type hinting a variable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type hinting for variables outside of method declarations- too much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants