Merge pull request #82 from NOAA-GSL/chore/idsse-860/support-setting-ack-nack-timeout

Geary-Layne · web-flow · commit 372be1290feb · 2024-11-01T07:38:59.000-06:00
Removed default Queue argument dict
diff --git a/python/idsse_common/idsse/common/rabbitmq_utils.py b/python/idsse_common/idsse/common/rabbitmq_utils.py
@@ -70,7 +70,7 @@ class Queue(NamedTuple):
     durable: bool
     exclusive: bool
     auto_delete: bool
-    arguments: dict = {'x-queue-type': 'classic'}
+    arguments: dict = {}
 
 
 class RabbitMqParams(NamedTuple):
diff --git a/python/idsse_common/test/test_rabbitmq_utils.py b/python/idsse_common/test/test_rabbitmq_utils.py
@@ -102,7 +102,7 @@ def test_connection_params_works(monkeypatch: MonkeyPatch, mock_connection: Mock
         exclusive=RMQ_PARAMS.queue.exclusive,
         durable=RMQ_PARAMS.queue.durable,
         auto_delete=RMQ_PARAMS.queue.auto_delete,
-        arguments={'x-queue-type': 'classic'}
+        arguments={}
     )
 
     _channel.queue_bind.assert_called_once_with(
@@ -143,7 +143,7 @@ def test_private_queue_sets_ttl(monkeypatch: MonkeyPatch, mock_connection: Mock)
         exclusive=example_queue.exclusive,
         durable=example_queue.durable,
         auto_delete=example_queue.auto_delete,
-        arguments={'x-message-ttl': 10000, 'x-queue-type': 'classic'}
+        arguments={'x-message-ttl': 10000}
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ def test_connection_params_works(monkeypatch: MonkeyPatch, mock_connection: Mock`
`102`	`102`	`exclusive=RMQ_PARAMS.queue.exclusive,`
`103`	`103`	`durable=RMQ_PARAMS.queue.durable,`
`104`	`104`	`auto_delete=RMQ_PARAMS.queue.auto_delete,`
`105`		`- arguments={'x-queue-type': 'classic'}`
	`105`	`+ arguments={}`
`106`	`106`	`)`
`107`	`107`
`108`	`108`	`_channel.queue_bind.assert_called_once_with(`
`@@ -143,7 +143,7 @@ def test_private_queue_sets_ttl(monkeypatch: MonkeyPatch, mock_connection: Mock)`
`143`	`143`	`exclusive=example_queue.exclusive,`
`144`	`144`	`durable=example_queue.durable,`
`145`	`145`	`auto_delete=example_queue.auto_delete,`
`146`		`- arguments={'x-message-ttl': 10000, 'x-queue-type': 'classic'}`
	`146`	`+ arguments={'x-message-ttl': 10000}`
`147`	`147`	`)`
`148`	`148`
`149`	`149`