bug: FileBasedLock parent dir may not exist #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue
N/A (hotfix)
Changes
.lock
fileExplanation
The previous PR (#104), once used by DAS, was throwing uncaught exceptions:
We failed to consider when FileBasedLock would be used to write data to a directory that didn't yet exist.
Now FileBasedLock will create (but not clean up) any parent directories above the provided filepath, before creating the
.lock
.