Skip to content

bug: catch error on FileBasedLock release() #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

bug: catch error on FileBasedLock release() #107

merged 1 commit into from
May 14, 2025

Conversation

@mackenzie-grimes-noaa
Copy link
Contributor

@mackenzie-grimes-noaa mackenzie-grimes-noaa commented May 13, 2025

Linear Issue

N/A

Changes

  • Some logs have shown uncaught errors when a service attempts to release a FileBasedLock: FileNotFoundError.
    • If we try to release a file lock, and it's already released, catch the error and assume the lock can be abandoned.

Explanation

N/A

@mackenzie-grimes-noaa mackenzie-grimes-noaa marked this pull request as ready for review May 14, 2025 16:26
@mackenzie-grimes-noaa mackenzie-grimes-noaa merged commit 628d72a into main May 14, 2025
2 checks passed
@mackenzie-grimes-noaa mackenzie-grimes-noaa deleted the bug/release-file-lock branch May 14, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mackenzie-grimes-noaa