Skip to content

Conversation

mackenzie-grimes-noaa
Copy link
Contributor

@mackenzie-grimes-noaa mackenzie-grimes-noaa commented May 14, 2025

Linear Issue

IDSSE-1243

Changes

  • RpcPublisher.send_request(): allow the TimeoutError to be raised and handled by the caller as it wishes.
    • Previously a WARNING level log was always printed and None was returned. This assumes we know how the caller wants timeouts to be handled.
    • Example: the DAS data_preload service intentionally times out because it doesn't care about the responses. Because of previous RpcPublisher code, WARNING logs were constantly printed to the console even when the service was performing nominally.

Note: this is a breaking change! Risk Processor and DAS data_preload currently expect send_request() to catch TimeoutErrors for them, and this PR would cause uncaught errors unless their code changes first.

Explanation

N/A

@mackenzie-grimes-noaa mackenzie-grimes-noaa marked this pull request as ready for review May 17, 2025 00:15
@mackenzie-grimes-noaa mackenzie-grimes-noaa merged commit 0913ddb into main May 19, 2025
2 checks passed
@mackenzie-grimes-noaa mackenzie-grimes-noaa deleted the bug/rpc-raise-timeout branch May 19, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant