bug: Unable to find appropriate packing #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue
IDSSE-1256
Changes
PackTypeoption to bit pack:INT.(2 ^ 32)or about 4.2 billionExplanation
Some NBM weather data had such a wide range of weather values that DAS web server would throw an error "Unable to find appropriate packing". For example, cloud ceiling caused this error because it had values from 100 ft to 291,000 ft.
This error was because the
bit_packmodule was at most packing data into "SHORT"-sized blocks, which go from 0 to 65,535. Now we can bit-pack data into INT-sized memory blocks. It's not nearly as efficient for disk space/network usage, but if the data values vary wildly it may sometimes be needed.