return 200, 'profiles': [] to non-NBM requests

Author: mackenzie-grimes-noaa

python/nwsc_proxy/ncp_web_service.py

@@ -57,7 +57,7 @@ def handler(self):
         # otherwise, must be 'GET' operation
         data_source = request.args.get('dataSource', None, type=str)
         if data_source not in ['NBM', 'ANY']:
-            return jsonify({'profiles': [], 'errors': [f'Invalid dataSource: {data_source}']}), 400
+            return jsonify({'profiles': [], 'errors': []}), 200
 
         profile_status = request.args.get('status', default='existing', type=str)
         if profile_status == 'existing':

python/nwsc_proxy/test/test_ncp_web_service.py

@@ -111,11 +111,12 @@ def test_events_bad_key(wrapper: AppWrapper, mock_request: Mock):
 
 
 def test_get_bad_data_source(wrapper: AppWrapper, mock_request: Mock):
-    mock_request.args = MultiDict({'dataSource': 'A BAD DATA SOURCE'})
+    mock_request.args = MultiDict({'dataSource': 'MYSTERY DATA SOURCE'})
 
     result: tuple[Response, int] = wrapper.app.view_functions['events']()
 
-    assert result[1] == 400
+    assert result[0].json['profiles'] == []
+    assert result[1] == 200
 
 
 def test_get_bad_status(wrapper: AppWrapper, mock_request: Mock):