feat: support "includeInactive" query param #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue
N/A
Changes
includeInactiveon GET requestsincludeInactivequery param included, NWSC Proxy returns profiles whether or not they haveisLive: falsein their JSONExplanation
These changes let us "turn off" a profile from future IDSSE processing without permanently deleting the profile and all its data. Previously we had to nuke any Profile in the Proxy, erasing all history, if we wanted to stop it from generating Event Portfolios.
By default, the NWSC Gateway (which feeds Risk Processor) will continue to only see Support Profiles in the NWSC Proxy that have
isLive: false. However, the NOAA UI a.k.a. Criteria Builder needs a way to query all existing Profiles, so users can see deactivated Profiles and reactivate them if needed.