#138 Refactoring and Testing of the Boundary Class #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e methods in unit tests
…ean, test_formalise_boundaries
jdha
reviewed
Nov 22, 2023
jdha
reviewed
Nov 22, 2023
jdha
requested changes
Nov 22, 2023
|
@jdha, the docstrings are now consistent with the format used throughout the rest of the codebase. Additionally, it appears that updating the cookiecutter template using make template-update is necessary. Any merging conflicts arising from this update should be resolved to ensure the successful completion of the pre-commit step in the CI workflow. In spite of that, I believe this PR is ready for merging, as this update is a separate issue. |
|
This was never merged? Can we get these changes incorporated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following modifications, addressing issue #138:
Boundaryclass for improved functionality.Boundaryclass, which is defined within thenemo_bdy_gen_c.py file. The original version of theBoundaryclass can be found in thenemo_bdy_gen_c_old.pyfile.