refactor ybus code #177
Merged
refactor ybus code #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
reviewed
Aug 11, 2025
jd-lara
reviewed
Aug 11, 2025
jd-lara
requested changes
Aug 11, 2025
jd-lara
reviewed
Aug 11, 2025
jd-lara
reviewed
Aug 11, 2025
jd-lara
reviewed
Aug 11, 2025
jd-lara
reviewed
Aug 11, 2025
|
I'll remove the macros, and put the 3WT code back to how it was. |
m-bossart
requested changes
Aug 12, 2025
There was a problem hiding this comment.
We can update this with the name changes in PowerSystems: NREL-Sienna/PowerSystems.jl#1511
jd-lara
reviewed
Aug 15, 2025
| return | ||
| end | ||
|
|
||
| _get_shunt(br::PSY.ACTransmission, node::Symbol) = |
There was a problem hiding this comment.
There is some mild type piracy here but it isn't outrageous
jd-lara
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some of the copy-pastes in computing the ybus entries with multiple dispatch. Some of this infrastructure (
_get_angle,_get_tap,TransformerWindingDispatch) could be moved into PSY if desired.(In order to recover the flows after a degree 2 reduction, I need to go from the component to the the 4
y_{ff/tf/ft/tt}numbers. Since I was refactoring things anyway, I decided to take the time to figure out how to de-duplicate things.)