Consolidate Sauer Pai model and add Static Load post processing currents #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test incomplete * progress on tests * test edits and placeholder csv file * updated dynamic_test_data Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu> Co-authored-by: m-bossart <bossart.matt@gmail.com>
|
Performance Results
ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 89.91% 90.71% +0.79%
==========================================
Files 63 63
Lines 7110 7246 +136
==========================================
+ Hits 6393 6573 +180
+ Misses 717 673 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address part of #277
Testing for this are not done yet.
Documentation still missing for SauerPai model.