Correct typo in configure_logging#395
Merged
rodrigomha merged 1 commit intoNREL-Sienna:rh/bump_to_psy4from Jul 8, 2025
Merged
Conversation
jd-lara
added a commit
that referenced
this pull request
Jul 9, 2025
* add unique timestamp to missing methods * Add ST8C, DEGOV1 and TGSimple models. Also, remove Windows PR Testing temporarily (#390) * add st8c model * add initialization routine * add test data * add ST8C field voltage post processing * add test 60 * remove windows from test temporarily * also remove windows test in PR testing temporarily * formatter * update test names * add tgsimple model * add test 62 tgsimple * update test 62 typos * add degov1 model * add degov1 test * fix typo * update uniquestamps methods * add doi to the arxiv in README.md (#397) * WIP fix test on missing `unique_timestamps` (#399) * fix missing unique_timestamps * explicit missing state * add default true Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu> * _mechanical_torque unique_timestamps default to true --------- Co-authored-by: Muhammad Yasirroni <yasirroni@users.noreply.github.com> Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu> Co-authored-by: Rodrigo Henríquez-Auba <rodrigomha@gmail.com> * add default unique timestamp * LOG_FILENAME -> SIMULATION_LOG_FILENAME (#395) * Update compat to PowerFlows.jl v0.9.0 (#400) * fix missing unique_timestamps * explicit missing state * add default true Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu> * _mechanical_torque unique_timestamps default to true * fix missing bus_count on _check_residual * support PowerFlows 0.9 * fix using solve_powerflow instead of _newton_powerflow * add back PowerNetworkMatrices = "^0.12.1" * use TrustRegionACPowerFlow for now * typo use PF for TrustRegionACPowerFlow --------- Co-authored-by: Muhammad Yasirroni <yasirroni@users.noreply.github.com> Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu> Co-authored-by: Rodrigo Henríquez-Auba <rodrigomha@gmail.com> * add avr docs * add turbine governor docs --------- Co-authored-by: Muhammad Yasirroni <48709672+yasirroni@users.noreply.github.com> Co-authored-by: Muhammad Yasirroni <yasirroni@users.noreply.github.com> Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu> Co-authored-by: Robert Parker <Robbybp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOG_FILENAMEappears to be undefined. IsSIMULATION_LOG_FILENAMEthe right constant to use instead?