Skip to content

Update compat to PowerFlows.jl v0.9.0 #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yasirroni
Copy link

This PR aims to update dependency to PowerFlows.jl v0.9.0.

The only breaking test are:

test_case59_st6b and test_case57_degov as shown in #398

and

test_case49_csvgn1 in NREL-Sienna/PowerFlows.jl#159

@jd-lara
Copy link
Member

jd-lara commented Apr 29, 2025

This is a pretty nice contribution we have been needing to this for a while

@jd-lara jd-lara requested review from rodrigomha and Copilot April 29, 2025 16:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency to PowerFlows.jl v0.9.0 by modifying the tutorial code to use the new API, addressing known breaking test cases.

  • Update function calls to reflect PowerFlows.jl v0.9.0
  • Modify the tutorial example to instantiate ACPowerFlow and use solve_powerflow!
Files not reviewed (10)
  • src/base/nlsolve_wrapper.jl: Language not supported
  • src/base/simulation_initialization.jl: Language not supported
  • src/base/simulation_results.jl: Language not supported
  • src/post_processing/post_proc_generator.jl: Language not supported
  • test/test_case_5shaft.jl: Language not supported
  • test/test_case_anderson.jl: Language not supported
  • test/test_case_marconato.jl: Language not supported
  • test/test_case_oneDoneQ.jl: Language not supported
  • test/test_case_simple_anderson.jl: Language not supported
  • test/test_case_simple_marconato.jl: Language not supported

@rodrigomha
Copy link
Contributor

Thanks for this @yasirroni
Feel free to join our slack here if you want to keep more involved with the development: https://join.slack.com/t/nrel-sienna/shared_invite/zt-glam9vdu-o8A9TwZTZqqNTKHa7q3BpQ

We haven't really have a lot of time and funding to continue the development here. I will try to consolidate all the relevant PRs in a single PR for the update and make a proper release. The main issue we had before was a problem with the Windows tests that were failing due to some issue in a library to compute eigenvectors.

@rodrigomha
Copy link
Contributor

Test seems to be failing in PowerNetworkMatrices dependency though

@yasirroni
Copy link
Author

yasirroni commented May 1, 2025

Feel free to join our slack
Sure.

Test seems to be failing in PowerNetworkMatrices dependency though

PowerFlows.jl v0.9.0 should lock PowerNetworkMatrices "^0.12.1" based on PowerFlows Project.toml. I don't see any error caused by that. If you can point me to one, I will try to inspect that.

@yasirroni
Copy link
Author

There was a typo that I didn't remove PowerNetworkMatrices from Project.toml. Regardless, I add back PowerNetworkMatrices = "^0.12.1". But in my opinion, it would be better and simpler if we remove PowerSystems and PowerNetworkMatrices dependency, and let PowerFlows that depends on it. But, I'm coming from Python, so not sure what is the best practice here in Julia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants