-
Notifications
You must be signed in to change notification settings - Fork 50
Update compat to PowerFlows.jl v0.9.0 #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu>
This is a pretty nice contribution we have been needing to this for a while |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dependency to PowerFlows.jl v0.9.0 by modifying the tutorial code to use the new API, addressing known breaking test cases.
- Update function calls to reflect PowerFlows.jl v0.9.0
- Modify the tutorial example to instantiate ACPowerFlow and use solve_powerflow!
Files not reviewed (10)
- src/base/nlsolve_wrapper.jl: Language not supported
- src/base/simulation_initialization.jl: Language not supported
- src/base/simulation_results.jl: Language not supported
- src/post_processing/post_proc_generator.jl: Language not supported
- test/test_case_5shaft.jl: Language not supported
- test/test_case_anderson.jl: Language not supported
- test/test_case_marconato.jl: Language not supported
- test/test_case_oneDoneQ.jl: Language not supported
- test/test_case_simple_anderson.jl: Language not supported
- test/test_case_simple_marconato.jl: Language not supported
Thanks for this @yasirroni We haven't really have a lot of time and funding to continue the development here. I will try to consolidate all the relevant PRs in a single PR for the update and make a proper release. The main issue we had before was a problem with the Windows tests that were failing due to some issue in a library to compute eigenvectors. |
Test seems to be failing in PowerNetworkMatrices dependency though |
|
There was a typo that I didn't remove |
This PR aims to update dependency to
PowerFlows.jl v0.9.0
.The only breaking test are:
test_case59_st6b
andtest_case57_degov
as shown in #398and
test_case49_csvgn1
in NREL-Sienna/PowerFlows.jl#159