Skip to content

Documentation new PR#1390

Merged
jd-lara merged 94 commits into
jd/psy45_docsv3from
jd/psy45_docsv2
Jun 30, 2025
Merged

Documentation new PR#1390
jd-lara merged 94 commits into
jd/psy45_docsv3from
jd/psy45_docsv2

Conversation

@jd-lara
Copy link
Copy Markdown
Member

@jd-lara jd-lara commented May 14, 2025

@kdayday @daniel-thom @rodrigomha I merged and opened a new PR because in Github the 50+ comments was making the page super slow to load. I handled most of the comments.

I probably still need to write more for the hydro piece but this is already covering the needed parts in sufficient detail even if we do more changes later.

closes #1213 too

@kdayday
Copy link
Copy Markdown
Contributor

kdayday commented May 16, 2025

@jd-lara I can take a look today, but the documentation is currently failing with a set up block error

@jd-lara
Copy link
Copy Markdown
Member Author

jd-lara commented May 20, 2025

@kdayday the docs build is broken because it requires the newer version of case builder.

@rodrigomha
Copy link
Copy Markdown
Contributor

Add explanation of level_data_type in HydroReservoirs (Total Volume, Usable Volume, Head and Energy).

@jd-lara
Copy link
Copy Markdown
Member Author

jd-lara commented Jun 2, 2025

add explanation for the Buses available field

@m-bossart
Copy link
Copy Markdown
Contributor

add explanation of new base voltage fields in transformers

Copy link
Copy Markdown
Contributor

@kdayday kdayday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go once the three recent comments are addressed (reservoir levels, buses available, voltage fields in transformers). I could compile it locally, but still didn't get all the PCSB examples working, so there could still be errors there. I assume some of those are due to the issues in the dev chat yesterday.

I also added links in the new hydro documentation. Please check the hydro how-to to make sure I captured that correctly.

I thinned out the how-to's that are now redundant and reorganized them so hopefully it's a little easier to navigate. Feedback welcome!

@jd-lara jd-lara changed the base branch from psy5 to jd/psy45_docsv3 June 30, 2025 01:07
@jd-lara jd-lara merged commit c4f9fe3 into jd/psy45_docsv3 Jun 30, 2025
1 of 9 checks passed
@jd-lara jd-lara deleted the jd/psy45_docsv2 branch July 17, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants