Skip to content

Conversation

STREM-hexagon
Copy link

The numbers for creating the inplane rotations are clearly given in degrees, but the code for creating the rotation matrix expects radians. This PR adds a conversion to fix this.
This fixes #73, but differs from the solution proposed in the issue by making the conversion outside of the loop for efficiency.

@yuanknv
Copy link

yuanknv commented Aug 13, 2025

Thanks for catching and fixing this, it looks good to me. We will include this fix in the next patch for release-3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential rotation parameter unit mismatch in MakeRotationGrid (degrees vs radians)
2 participants